refactor: drop unused message timestamp and max-age filter

Author: EhabY

CHANGELOG.md

@@ -7,6 +7,12 @@
 
 ## Unreleased
 
+### Added
+
+- Opening a workspace that's already connected in another VS Code window now shows a prompt
+  to **Duplicate Window** (preserving tabs and panels) or **Open Without Folder**, instead of
+  just focusing the existing window with no way to open a second view of the same workspace.
+
 ### Fixed
 
 - The **Coder: Workspace Build** output channel is no longer created when reconnecting to an

src/workspace/duplicateWorkspaceIpc.ts

@@ -7,7 +7,6 @@ import type { Disposable, SecretStorage } from "vscode";
 
 import type { Logger } from "../logging/logger";
 
-const MESSAGE_MAX_AGE_MS = 5000;
 const DEFAULT_PING_TIMEOUT_MS = 1000;
 
 const REQUEST_KEY = "coder.ipc.req";
@@ -17,21 +16,18 @@ const PingMessageSchema = z.object({
 	type: z.literal("ping"),
 	id: z.string(),
 	authority: z.string(),
-	ts: z.number(),
 });
 
 const PongMessageSchema = z.object({
 	type: z.literal("pong"),
 	id: z.string(),
 	sessionId: z.string(),
-	ts: z.number(),
 });
 
 const DuplicateMessageSchema = z.object({
 	type: z.literal("duplicate"),
 	id: z.string(),
 	targetSessionId: z.string(),
-	ts: z.number(),
 });
 
 const RequestMessageSchema = z.discriminatedUnion("type", [
@@ -104,7 +100,7 @@ export class DuplicateWorkspaceIpc {
 			const timer = setTimeout(() => settle(undefined), timeoutMs);
 
 			this.requests
-				.send({ type: "ping", id, authority, ts: Date.now() })
+				.send({ type: "ping", id, authority })
 				.then(undefined, (err: unknown) => {
 					this.logger.error("Failed to send IPC ping", err);
 					settle(undefined);
@@ -117,7 +113,6 @@ export class DuplicateWorkspaceIpc {
 			type: "pong",
 			id: pingId,
 			sessionId,
-			ts: Date.now(),
 		});
 	}
 
@@ -127,19 +122,12 @@ export class DuplicateWorkspaceIpc {
 			type: "duplicate",
 			id: crypto.randomUUID(),
 			targetSessionId,
-			ts: Date.now(),
 		});
 	}
 
-	/** Listen for incoming requests. Stale messages are dropped. */
 	onRequest(
 		handler: (msg: RequestMessage) => void | Promise<void>,
 	): Disposable {
-		return this.requests.onReceive((msg) => {
-			if (Date.now() - msg.ts > MESSAGE_MAX_AGE_MS) {
-				return;
-			}
-			return handler(msg);
-		});
+		return this.requests.onReceive(handler);
 	}
 }

test/unit/workspace/duplicateWorkspaceIpc.test.ts

@@ -46,35 +46,6 @@ describe("DuplicateWorkspaceIpc", () => {
 		expect(await promise).toBeUndefined();
 	});
 
-	it("delivers fresh requests but drops stale ones", async () => {
-		const { secrets, sender, receiver } = makeIpcPair();
-		const handler = vi.fn();
-		receiver.onRequest(handler);
-
-		// Replay an old request directly through storage.
-		await secrets.store(
-			"coder.ipc.req",
-			JSON.stringify({
-				type: "ping",
-				id: "old",
-				authority: "ssh-remote+host",
-				ts: Date.now() - 10_000,
-			}),
-		);
-		await vi.advanceTimersByTimeAsync(10);
-		expect(handler).not.toHaveBeenCalled();
-
-		// A fresh sendDuplicate should be delivered.
-		await sender.sendDuplicate("session-fresh");
-		await vi.advanceTimersByTimeAsync(10);
-		expect(handler).toHaveBeenCalledWith(
-			expect.objectContaining({
-				type: "duplicate",
-				targetSessionId: "session-fresh",
-			}),
-		);
-	});
-
 	it("supports the full ping → pong → duplicate round trip", async () => {
 		const { secrets, sender } = makeIpcPair();
 		const duplicateReceived = vi.fn();