Add additional error metadata. (#8)

Author: nowells

lib/index.js

@@ -32,22 +32,29 @@ function spawn(command, args, options, done) {
     child.on('error', onerror)
     child.on('close', onclose)
 
+    function fixUpError(error) {
+      error.stdout = out
+      error.stderr = err
+      error.command = command
+      error.args = args
+      error.options = options
+      error.killed = child.killed
+      return error
+    }
+
     function onerror(err) {
       cleanup()
-      done(err)
+      done(fixUpError(err))
     }
 
     function onclose(code, signal) {
       cleanup()
       if (code === 0 && signal == null) return done(null, out)
 
       var error = new Error('Command failed: ' + command + '\n' + err)
-      error.stdout = out
-      error.stderr = err
-      error.killed = child.killed
       error.code = code
       error.signal = signal
-      done(error)
+      done(fixUpError(error))
     }
 
     function onoutdata(chunk) {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "co-child-process",
   "description": "easily spawn a child process with co",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "author": {
     "name": "Jonathan Ong",
     "email": "[email protected]",

test/spawn.js

@@ -24,22 +24,30 @@ describe('co-spawn', function () {
 
   it('should work with spawn errors', () => co(function* () {
     try {
-      yield spawn('laksjdflkajsdf')
+      yield spawn('laksjdflkajsdf', ['foo', 'bar'], {cwd: __dirname})
       throw new Error('wtf')
     } catch (err) {
       err.code.should.equal('ENOENT')
+      err.stdout.should.equal('')
+      err.stderr.should.equal('')
+      err.command.should.equal('laksjdflkajsdf')
+      err.args.should.deepEqual(['foo', 'bar'])
+      err.options.should.deepEqual({cwd: __dirname})
     }
   }))
 
   it('should work with program errors', () => co(function* () {
     try {
-      yield spawn(path.join(__dirname, 'fixtures', 'error-bin.js'))
+      yield spawn(path.join(__dirname, 'fixtures', 'error-bin.js'), ['foo', 'bar'], {cwd: __dirname})
       throw new Error('wtf')
     } catch (err) {
       err.code.should.equal(1)
       err.stdout.should.equal('stdout output\n')
       err.stderr.should.containEql('stderr output\n')
       err.stderr.should.containEql('Error: Error message\n')
+      err.command.should.equal(path.join(__dirname, 'fixtures', 'error-bin.js'))
+      err.args.should.deepEqual(['foo', 'bar'])
+      err.options.should.deepEqual({cwd: __dirname})
     }
   }))
 })