Rename exception args; add types

Author: colinodell

CHANGELOG.md

@@ -11,6 +11,10 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
    - `$source` is now `$json`
    - `$options` is now `$flags`
  - Added explicit `mixed` return type to match `json_decode()`
+ - Added proper types to all parameters and return values of `SyntaxError`
+ - Renamed two arguments in the `SyntaxError`'s constructor:
+   - `$linenumber` is now `$lineNumber`
+   - `$columnNumber` is now `$column`
 
 ### Removed
  - Removed support for PHP 7.x (8.0+ is now required)

src/SyntaxError.php

@@ -16,42 +16,23 @@
 
 final class SyntaxError extends \JsonException
 {
-    /** @var int */
-    private $lineNumber;
-
-    /** @var int */
-    private $column;
-
-    /**
-     * SyntaxError constructor.
-     *
-     * @param string          $message
-     * @param int             $linenumber
-     * @param int             $columnNumber
-     * @param \Throwable|null $previous
-     */
-    public function __construct($message, $linenumber, $columnNumber, $previous = null)
-    {
-        $message = \sprintf('%s at line %d column %d of the JSON5 data', $message, $linenumber, $columnNumber);
+    public function __construct(
+        string          $message,
+        private int     $lineNumber,
+        private int     $column,
+        \Throwable|null $previous = null
+    ) {
+        $message = \sprintf('%s at line %d column %d of the JSON5 data', $message, $lineNumber, $column);
 
         parent::__construct($message, 0, $previous);
-
-        $this->lineNumber = $linenumber;
-        $this->column = $columnNumber;
     }
 
-    /**
-     * @return int
-     */
-    public function getLineNumber()
+    public function getLineNumber(): int
     {
         return $this->lineNumber;
     }
 
-    /**
-     * @return int
-     */
-    public function getColumn()
+    public function getColumn(): int
     {
         return $this->column;
     }