Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for ES indexes in searchResults should also check REQUEST #32

Open
ewohnlich opened this issue Sep 21, 2017 · 0 comments
Open

Check for ES indexes in searchResults should also check REQUEST #32

ewohnlich opened this issue Sep 21, 2017 · 0 comments

Comments

@ewohnlich
Copy link
Contributor

Currently this method checks if there is an ES index passed in the kw parameter, but it may be passed in the REQUEST parameter. It is basically the difference between calling catalog(query) (REQUEST) and catalog(**query) (kw). If the former is called (I noticed it does this in plone.app.vocabularies.catalog) what happens is ElasticSearchCatalog determines it is not relevant to ES and sends it to the default catalog search, but if you've deleted your SearchableText index there it effectively ignores that index.

You probably want to have the searchResults method first build query out of REQUEST and kw and then check that for relevance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant