From cfe1583c3ef2ac649d54205dd8d70d5aa5d170bf Mon Sep 17 00:00:00 2001 From: Daren Jacobs Date: Tue, 28 Jul 2026 11:42:36 -0400 Subject: [PATCH] DND-1485: default rds_backup_retention_period 14 -> 7 to match STSaaS norm The previous default (14) silently doubled Aurora continuous-backup storage and cost for every customer that migrated onto this module without an override (DND-1323), surfaced as DND-1485 (Zoox RDS cost ~4x in July). The STSaaS standard recovery window is 7 days. Customer wrappers that were pinned back to 7 in comet-devops#2108 are the band-aid; this fixes the source so the six envs still on comet-ml/comet/aws 3.x (netflix + bmw the large ones) don't re-inherit 14 the moment they migrate. README default row already reads 7, so it is now consistent with variables.tf (the stale 7-vs-14 mismatch is resolved). terraform-docs not regenerated wholesale: the README has no injection markers and the tool isn't pinned locally, so a full regen would churn the entire table on a different version. Co-Authored-By: Claude Opus 4.8 --- variables.tf | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/variables.tf b/variables.tf index 958cfb0..2180f1e 100644 --- a/variables.tf +++ b/variables.tf @@ -1131,7 +1131,11 @@ variable "rds_iam_db_auth" { variable "rds_backup_retention_period" { description = "Days specified for RDS snapshot retention period" type = number - default = 14 + # DND-1485: STSaaS standard is a 7-day recovery window. The previous default (14) + # silently doubled Aurora continuous-backup storage/cost for every customer that + # migrated onto this module without an override (DND-1323). Default to 7 to match + # the fleet norm; customers wanting more set it explicitly. + default = 7 } variable "rds_preferred_backup_window" {