Repository navigation
DND-1485: default rds_backup_retention_period 14 to 7 (STSaaS fleet norm) - #51
Merged
Merged
Conversation
… norm The previous default (14) silently doubled Aurora continuous-backup storage and cost for every customer that migrated onto this module without an override (DND-1323), surfaced as DND-1485 (Zoox RDS cost ~4x in July). The STSaaS standard recovery window is 7 days. Customer wrappers that were pinned back to 7 in comet-devops#2108 are the band-aid; this fixes the source so the six envs still on comet-ml/comet/aws 3.x (netflix + bmw the large ones) don't re-inherit 14 the moment they migrate. README default row already reads 7, so it is now consistent with variables.tf (the stale 7-vs-14 mismatch is resolved). terraform-docs not regenerated wholesale: the README has no injection markers and the tool isn't pinned locally, so a full regen would churn the entire table on a different version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
liyaka
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
What
Change the module default
rds_backup_retention_period14 → 7 (variables.tf).Why
The
14default silently doubled Aurora continuous-backup storage/cost for every STSaaS customer that migrated onto this module without an override (DND-1323) — the pre-migration standard was 7. Surfaced as DND-1485 (Zoox RDS cost ~4× in July; DoiT/CloudTrail confirmed the 7→14 flip on the migration-apply date).comet-devops#2108 pins the already-migrated wrappers (bayer, circuit, circuit-dev, eonnext, mercedesamgf1, si, waystar, zoox) back to 7 — that's the band-aid. This PR fixes the source, so the envs still on
comet-ml/comet/aws3.x (netflix + bmw the large ones), which are on 7 only by inherited default, don't re-inherit 14 the moment they migrate.Notes
rds_backup_retention_periodexplicitly in their wrapper — this only changes the unset-default behaviour.7, so it is now consistent withvariables.tf(the stale 7-vs-14 mismatch Liya flagged — plausibly why this slipped through DND-1323 review — is resolved). terraform-docs was not regenerated wholesale: the README has noBEGIN/END_TF_DOCSinjection markers and the tool isn't pinned in this checkout, so a full regen would reformat the entire table on a mismatched version. A clean regen can run under the pinned CI version if desired.🤖 Generated with Claude Code
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Align
variables.tf'srds_backup_retention_perioddefault with the STSaaS 7-day standard used by RDS/Aurora backups. Preserve customer-specific retention windows by leaving explicitrds_backup_retention_periodoverrides unchanged.Latest Contributors(2)