-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support self-hosted gitlab URLs instead of having to fill out the long form #448
Comments
This issue has been mentioned on Common Workflow Language Discourse. There might be relevant details there: |
Hi, the URL provided, https://gitlab.inria.fr/capsid.public_codes/CroMaSt/-/blob/main/CroMaSt.cwl, does not pass the current regex tests in the JavaScript code cwlviewer/src/main/resources/static/js/main.js Lines 80 to 98 in 3088d53
There are two regular expressions, one for GitHub, and for for GitLab. Respectively:
So they expect that any URL provided to CWL Viewer starts with either github.com or gitlab.com. @swzCuroverse now with so many companies hosting their own internal GitLab servers, I think maybe we should consider supporting other ways to verify if a URL is hosted on GitLab, GitHub, or any other git server (e.g. the Apache Software Foundation uses primarily gitweb, https://gitbox.apache.org/, but allows other projects to change and use gitlab/github with a mirror to gitweb/gitbox). -Bruno |
This issue has been mentioned on Common Workflow Language Discourse. There might be relevant details there: |
From question on forum -- CWL-viewer seems to have issues viewing a cwl workflows form gitlabs-- I replicated it as well.
Link: https://gitlab.inria.fr/capsid.public_codes/CroMaSt/-/blob/main/CroMaSt.cwl
Link to question:
https://gitlab.inria.fr/capsid.public_codes/CroMaSt/-/blob/main/CroMaSt.cwl
I went and found a another CWL workflow from gitlabs here -- https://gitlab.com/iidsgt/biocwl/-/blob/master/Workflows/Build-RNA-Indexes.cwl and it also couldn't render it -- so it might be a general issue with gitlab URLs.
The text was updated successfully, but these errors were encountered: