Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permalink not visible on small screens #485

Open
mr-c opened this issue Dec 30, 2022 · 3 comments
Open

permalink not visible on small screens #485

mr-c opened this issue Dec 30, 2022 · 3 comments

Comments

@mr-c
Copy link
Member

mr-c commented Dec 30, 2022

Example https://view.commonwl.org/workflows/github.com/BD2KGenomics/dockstore_workflow_fusion/blob/master/fusion_workflow.cwl

Neither in mobile view, portrait mode

Screenshot_20221230-102402

Horizontal mode
Screenshot_20221230-102411

Nor desktop mode
Screenshot_20221230-102432

@kinow
Copy link
Member

kinow commented Dec 30, 2022

Looks like it was intentionally hidden on smaller viewports (CSS class hidden-xs).

The verified link:

<div class="col-md-6 text-right hidden-xs">
<img class="verification_icon" src="../static/img/tick.svg" th:src="@{/img/tick.svg}" width="20" height="22" /> Verified with cwltool version <samp th:text="${workflow.cwltoolVersion}">1.0.20170622090721</samp>
</div>

And the permalink:

<div class="permalink hidden-sm hidden-xs hidden-print">
Permalink:
<a href="https://w3id.org/cwl/view/" rel="noopener" class="help" target="_blank">[?]</a>
<a id="permalink" th:href="${workflow.permalink}" th:text="${workflow.permalink}"
href="#">https://w3id.org/cwl/view/git/933bf2a1a1cce32d88f88f136275535da9df0954/workflows/larger/test-hello.cwl</a>
</div>

@mr-c
Copy link
Member Author

mr-c commented Dec 30, 2022

Thanks for the quick sleuthing @kinow !

I think permalinks are pretty important, though I can see how they could screw up the layout. Maybe the intention was to just display an icon for small displays instead of the full URL?

@kinow
Copy link
Member

kinow commented Dec 30, 2022

That would make more sense, the smaller icon. I think the verified icon could also be displayed although it is useful to know the cwltool version as well.

@mr-c mr-c changed the title permalink not visible on Firefox for Android permalink not visible on small screens Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants