Skip to content

Commit 484d028

Browse files
jbowlerjcfr
authored andcommitted
[Backport generator] Eliminate warnings about #warning (#122)
The warnings are already only emitted with GCC so changing them to the GCC diagnostic pragma is safe. (cherry picked from commit MeVisLab/pythonqt@b454669)
1 parent 906ac59 commit 484d028

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

generator/parser/declarator_compiler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ void DeclaratorCompiler::visitPtrOperator(PtrOperatorAST *node)
135135
if (node->mem_ptr)
136136
{
137137
#if defined(__GNUC__)
138-
#warning "ptr to mem -- not implemented"
138+
#pragma GCC warning "ptr to mem -- not implemented"
139139
#endif
140140
}
141141
}

generator/parser/name_compiler.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ void NameCompiler::visitUnqualifiedName(UnqualifiedNameAST *node)
8080
if (OperatorFunctionIdAST *op_id = node->operator_id)
8181
{
8282
#if defined(__GNUC__)
83-
#warning "NameCompiler::visitUnqualifiedName() -- implement me"
83+
#pragma GCC warning "NameCompiler::visitUnqualifiedName() -- implement me"
8484
#endif
8585

8686
if (op_id->op && op_id->op->op)
@@ -93,7 +93,7 @@ void NameCompiler::visitUnqualifiedName(UnqualifiedNameAST *node)
9393
else if (op_id->type_specifier)
9494
{
9595
#if defined(__GNUC__)
96-
#warning "don't use an hardcoded string as cast' name"
96+
#pragma GCC warning "don't use an hardcoded string as cast' name"
9797
#endif
9898
Token const &tk = _M_token_stream->token ((int) op_id->start_token);
9999
Token const &end_tk = _M_token_stream->token ((int) op_id->end_token);

generator/parser/parser.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -840,7 +840,7 @@ bool Parser::parseAsmDefinition(DeclarationAST *&node)
840840
parseCvQualify(cv);
841841

842842
#if defined(__GNUC__)
843-
#warning "implement me"
843+
#pragma GCC warning "implement me"
844844
#endif
845845
skip('(', ')');
846846
token_stream.nextToken();
@@ -2427,7 +2427,7 @@ bool Parser::parseInitializerClause(InitializerClauseAST *&node)
24272427
if (token_stream.lookAhead() == '{')
24282428
{
24292429
#if defined(__GNUC__)
2430-
#warning "implement me"
2430+
#pragma GCC warning "implement me"
24312431
#endif
24322432
if (skip('{','}'))
24332433
token_stream.nextToken();
@@ -2451,7 +2451,7 @@ bool Parser::parseInitializerClause(InitializerClauseAST *&node)
24512451
bool Parser::parsePtrToMember(PtrToMemberAST *&node)
24522452
{
24532453
#if defined(__GNUC__)
2454-
#warning "implemente me (AST)"
2454+
#pragma GCC warning "implemente me (AST)"
24552455
#endif
24562456

24572457
std::size_t start = token_stream.cursor();
@@ -2625,15 +2625,15 @@ bool Parser::parseStatement(StatementAST *&node)
26252625
case Token_break:
26262626
case Token_continue:
26272627
#if defined(__GNUC__)
2628-
#warning "implement me"
2628+
#pragma GCC warning "implement me"
26292629
#endif
26302630
token_stream.nextToken();
26312631
ADVANCE(';', ";");
26322632
return true;
26332633

26342634
case Token_goto:
26352635
#if defined(__GNUC__)
2636-
#warning "implement me"
2636+
#pragma GCC warning "implement me"
26372637
#endif
26382638
token_stream.nextToken();
26392639
ADVANCE(Token_identifier, "identifier");
@@ -3279,7 +3279,7 @@ bool Parser::parseDeclarationInternal(DeclarationAST *&node)
32793279
ADVANCE(';', ";");
32803280

32813281
#if defined(__GNUC__)
3282-
#warning "mark the ast as constant"
3282+
#pragma GCC warning "mark the ast as constant"
32833283
#endif
32843284
SimpleDeclarationAST *ast = CreateNode<SimpleDeclarationAST>(_M_pool);
32853285
ast->init_declarators = declarators;
@@ -3380,7 +3380,7 @@ bool Parser::parseDeclarationInternal(DeclarationAST *&node)
33803380
bool Parser::skipFunctionBody(StatementAST *&)
33813381
{
33823382
#if defined(__GNUC__)
3383-
#warning "Parser::skipFunctionBody() -- implement me"
3383+
#pragma GCC warning "Parser::skipFunctionBody() -- implement me"
33843384
#endif
33853385
Q_ASSERT(0); // ### not implemented
33863386
return 0;
@@ -3409,7 +3409,7 @@ bool Parser::parseTypeSpecifierOrClassSpec(TypeSpecifierAST *&node)
34093409
bool Parser::parseTryBlockStatement(StatementAST *&node)
34103410
{
34113411
#if defined(__GNUC__)
3412-
#warning "implement me"
3412+
#pragma GCC warning "implement me"
34133413
#endif
34143414
CHECK(Token_try);
34153415

0 commit comments

Comments
 (0)