Skip to content

Commit

Permalink
include/spinlock: explicit casts for C++ compilation
Browse files Browse the repository at this point in the history
  • Loading branch information
thibault-martinez authored and pkhuong committed Jan 10, 2019
1 parent 7bd17e4 commit 8698ada
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion include/spinlock/clh.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ ck_spinlock_clh_lock(struct ck_spinlock_clh **queue, struct ck_spinlock_clh *thr
* Mark current request as last request. Save reference to previous
* request.
*/
previous = ck_pr_fas_ptr(queue, thread);
previous = CK_CPP_CAST(struct ck_spinlock_clh *, ck_pr_fas_ptr(queue, thread));
thread->previous = previous;

/* Wait until previous thread is done with lock. */
Expand Down
4 changes: 2 additions & 2 deletions include/spinlock/hclh.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ ck_spinlock_hclh_lock(struct ck_spinlock_hclh **glob_queue,
ck_pr_fence_store_atomic();

/* Mark current request as last request. Save reference to previous request. */
previous = ck_pr_fas_ptr(local_queue, thread);
previous = CK_CPP_CAST(struct ck_spinlock_hclh *, ck_pr_fas_ptr(local_queue, thread));
thread->previous = previous;

/* Wait until previous thread from the local queue is done with lock. */
Expand All @@ -107,7 +107,7 @@ ck_spinlock_hclh_lock(struct ck_spinlock_hclh **glob_queue,

/* Now we need to splice the local queue into the global queue. */
local_tail = ck_pr_load_ptr(local_queue);
previous = ck_pr_fas_ptr(glob_queue, local_tail);
previous = CK_CPP_CAST(struct ck_spinlock_hclh *, ck_pr_fas_ptr(glob_queue, local_tail));

ck_pr_store_uint(&local_tail->splice, true);

Expand Down
2 changes: 1 addition & 1 deletion include/spinlock/mcs.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ ck_spinlock_mcs_lock(struct ck_spinlock_mcs **queue,
* returns NULL, it means the queue was empty. If the queue was empty,
* then the operation is complete.
*/
previous = ck_pr_fas_ptr(queue, node);
previous = CK_CPP_CAST(struct ck_spinlock_mcs *, ck_pr_fas_ptr(queue, node));
if (previous != NULL) {
/*
* Let the previous lock holder know that we are waiting on
Expand Down

0 comments on commit 8698ada

Please sign in to comment.