Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvshmem 3.1.7 #28647

Merged
merged 12 commits into from
Feb 13, 2025
Merged

nvshmem 3.1.7 #28647

merged 12 commits into from
Feb 13, 2025

Conversation

billysuh7
Copy link
Contributor

@billysuh7 billysuh7 commented Dec 19, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Xref: #28111

Please also refer to https://docs.nvidia.com/nvshmem/release-notes-install-guide/install-guide/abstract.html for NVSHMEM requirements and how much this package were able/unable to meet.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/nvshmem/meta.yaml, recipes/libnvshmem/meta.yaml) and found some lint.

Here's what I've got...

For recipes/libnvshmem/meta.yaml:

  • ❌ The license item is expected in the about section.

For recipes/libnvshmem/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12416875254. Examine the logs at this URL for more detail.

@billysuh7 billysuh7 force-pushed the topic/bsuh/libnvshmem branch from c71139b to 19e4343 Compare December 19, 2024 16:40
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 19, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nvshmem/meta.yaml, recipes/libnvshmem/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/libnvshmem/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12835109483. Examine the logs at this URL for more detail.

@billysuh7 billysuh7 force-pushed the topic/bsuh/libnvshmem branch from 19e4343 to 40d4c1f Compare December 19, 2024 21:17
@billysuh7 billysuh7 force-pushed the topic/bsuh/libnvshmem branch from 40d4c1f to a82dd91 Compare December 19, 2024 21:54
rdma-core: MOFED provides it
openmpi: DOE/DOD supercomputing clusters have their own versions of MPI installed already
libfabric: Slingshot and EFA NIC have a custom version and plugin
@billysuh7 billysuh7 marked this pull request as ready for review January 17, 2025 19:41
@billysuh7
Copy link
Contributor Author

@conda-forge/cuda please review

recipes/nvshmem/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvshmem/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvshmem/build-libnvshmem.sh Outdated Show resolved Hide resolved
recipes/libnvshmem/build-libnvshmem.sh Outdated Show resolved Hide resolved
recipes/libnvshmem/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvshmem/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvshmem/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvshmem/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libnvshmem/meta.yaml) and found some lint.

Here's what I've got...

For recipes/libnvshmem/meta.yaml:

For recipes/libnvshmem/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13269709230. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libnvshmem/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/libnvshmem/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13316318203. Examine the logs at this URL for more detail.

recipes/libnvshmem/build-libnvshmem.sh Outdated Show resolved Hide resolved
recipes/libnvshmem/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvshmem/meta.yaml Outdated Show resolved Hide resolved
recipes/libnvshmem/build-libnvshmem.sh Outdated Show resolved Hide resolved
recipes/libnvshmem/build-libnvshmem.sh Outdated Show resolved Hide resolved
@carterbox carterbox merged commit 6ae3404 into conda-forge:main Feb 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants