Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fastembed #28967

Merged
merged 16 commits into from
Feb 14, 2025
Merged

add fastembed #28967

merged 16 commits into from
Feb 14, 2025

Conversation

moritzwilksch
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 28, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/fastembed/recipe.yaml, recipes/py-rust-stemmers/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/py-rust-stemmers/recipe.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

For recipes/py-rust-stemmers/recipe.yaml:

  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13015439110. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/py-rust-stemmers/recipe.yaml, recipes/fastembed/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/py-rust-stemmers/recipe.yaml:

  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13015467373. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/py-rust-stemmers/recipe.yaml, recipes/fastembed/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/fastembed/recipe.yaml, recipes/py-rust-stemmers/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/fastembed/recipe.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13264816711. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/py-rust-stemmers/recipe.yaml, recipes/fastembed/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13286206003. Examine the logs at this URL for more detail.

@moritzwilksch
Copy link
Member Author

we should be able to remove the <3.13 pin after conda-forge/mmh3-feedstock#25 is merged

@moritzwilksch moritzwilksch marked this pull request as draft February 12, 2025 09:08
@moritzwilksch moritzwilksch changed the title add fastembed an py-rust-stemmers add fastembed Feb 12, 2025
@moritzwilksch
Copy link
Member Author

depends on #29104

@moritzwilksch moritzwilksch marked this pull request as ready for review February 12, 2025 13:34
@moritzwilksch
Copy link
Member Author

@conda-forge/help-python, ready for review!

@wolfv the linter still doesn't seem to like the conditional syntax of v1 recipes, similar to here. Can we still merge this?

@wolfv
Copy link
Member

wolfv commented Feb 12, 2025

Ah yes, because it's a noarch package. What you are looking for is the conditional dependencies that we are currently proposing in a CEP.

For a noarch package, only a single repodata entry will be created that has to be valid for all Python versions.

There are a number of workarounds to this issue but they all involve creating additional packages.

@moritzwilksch
Copy link
Member Author

ahh I see 🥲 why did it work for the nested syntax though? Did it just fill one of the versions and that worked although it wasn't a conditional specification anymore?

As a fix, can I just bump the min_python to a version that doesn't require the complex conditionals?

@wolfv
Copy link
Member

wolfv commented Feb 12, 2025

Yeah, only one of your combinations would have made it into the metadata.

@wolfv
Copy link
Member

wolfv commented Feb 12, 2025

You can totally restrict the Python version that works with your package.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/fastembed/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/fastembed/recipe.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of recipe, you should usually use python ${{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13289401845. Examine the logs at this URL for more detail.

@moritzwilksch
Copy link
Member Author

done! is this fine?

@wolfv wolfv merged commit c557d1d into conda-forge:main Feb 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants