-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get dist-s1 into conda-forge #29084
get dist-s1 into conda-forge #29084
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/dist-s1/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13267037046. Examine the logs at this URL for more detail. |
@conda-forge-admin, please lint |
@conda-forge-admin, please add user @cmarshak as a maintainer |
I agree to be a maintainer! |
@conda-forge-admin, please lint |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python, ready for review! |
requires: | ||
- pip | ||
- python {{ python_min }} | ||
- pyyaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that @ocefpaf already merged this, but pyyaml
and dist_s1_enumerator
shouldn't be in the test
/requires
section if it's listed under requirements
/run
. If you were seeing that not having those was causing an error then something is wrong. Otherwise, please remove these in the next release to the feedstock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We will do.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).