Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for synchronicity #29088

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Conversation

devennavani
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/synchronicity/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/synchronicity/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13256855046. Examine the logs at this URL for more detail.

@devennavani devennavani changed the title Add synchronicity package Add recipe for synchronicity Feb 11, 2025
@devennavani devennavani marked this pull request as ready for review February 11, 2025 05:04
@devennavani
Copy link
Contributor Author

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

Copy link
Contributor

github-actions bot commented Feb 11, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/synchronicity/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: freider, mwaskom, aksh-at, erikbern. Please ask them to comment on this PR if they are.

@devennavani
Copy link
Contributor Author

devennavani commented Feb 11, 2025

I have asked @aksh-at, @erikbern, @freider, and @mwaskom to comment on this PR -- they will do so shortly.

@freider
Copy link

freider commented Feb 11, 2025

Confirming I am willing to be listed as a maintainer of this recipe.

3 similar comments
@mwaskom
Copy link

mwaskom commented Feb 11, 2025

Confirming I am willing to be listed as a maintainer of this recipe.

@erikbern
Copy link

Confirming I am willing to be listed as a maintainer of this recipe.

@aksh-at
Copy link

aksh-at commented Feb 11, 2025

Confirming I am willing to be listed as a maintainer of this recipe.

Copy link
Member

@synapticarbors synapticarbors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes to satisfy the linter requirements for noarch: python packages:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python

Also added the dev_url since I find it handy to have access to. Feel free to merge the suggested changes or just roll them into a commit yourself.

recipes/synchronicity/meta.yaml Outdated Show resolved Hide resolved
recipes/synchronicity/meta.yaml Outdated Show resolved Hide resolved
recipes/synchronicity/meta.yaml Show resolved Hide resolved
recipes/synchronicity/meta.yaml Show resolved Hide resolved
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/synchronicity/meta.yaml) and found it was in an excellent condition.

@devennavani
Copy link
Contributor Author

@synapticarbors Thank you for the prompt review! I've incorporated your feedback -- lmk if you'd like to see any other changes.

@synapticarbors synapticarbors merged commit 07fd551 into conda-forge:main Feb 11, 2025
7 checks passed
@devennavani devennavani deleted the synchronicity branch February 11, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants