Use longer repoids in ubi.repo #3003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
IIUC this file is used by Mintmaker. It was added in EC-1244 to prevent Mintmaker from failing. More specifically it's used by `rpm-lockfile-prototype` which IIUC Mintmaker is using to freshen rpm lockfiles. For this change I'm hoping to prevent the "good" repoids (such as "ubi-9-for-aarch64-baseos-rpms" from being converted to "bad" repoids (such as "ubi-9-baseos-rpms") in our `rpms.lock.yaml file`, in PRs such as conforma#2934. The "bad" repoids can produce Conforma violations, since the shorter repoids are not in the allowed repo list, visible [here](https://github.com/release-engineering/rhtap-ec-policy/blob/main/data/known_rpm_repositories.yml). See also the `hack/update-rpm-lock.sh` script in this repo, which is our own custom script we've used in the past for updating the rpm lockfile.
simonbaird
force-pushed
the
longer-ubi-repoids
branch
from
e3ff5cc to
25ab3a2
Compare
st3penta
approved these changes
Oct 13, 2025
Member
Author
|
We're ignoring the spurious Sealights failures currently. Let's merge this and see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC this file is used by Mintmaker. It was added in EC-1244 to prevent Mintmaker from failing. More specifically it's used by
rpm-lockfile-prototypewhich IIUC Mintmaker is using to freshen rpm lockfiles.For this change I'm hoping to prevent the "good" repoids (such as "ubi-9-for-aarch64-baseos-rpms" from being converted to "bad" repoids (such as "ubi-9-baseos-rpms") in our
rpms.lock.yaml file, in PRs such as #2934.The "bad" repoids can produce Conforma violations, since the shorter repoids are not in the allowed repo list, visible here.
See also the
hack/update-rpm-lock.shscript in this repo, which is our own custom script we've used in the past for updating the rpm lockfile.