Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release NRI with the same process as containerd #143

Closed
chrishenzie opened this issue Feb 19, 2025 · 1 comment
Closed

Release NRI with the same process as containerd #143

chrishenzie opened this issue Feb 19, 2025 · 1 comment

Comments

@chrishenzie
Copy link
Contributor

containerd appears to follow a different release process (containerd/containerd#11356) that uses the release-tool for building notes.

NRI release notes have their own format. Is this generated a different way or done by hand? Would it be worth migrating NRI to this same release process to consolidate them across projects?

@samuelkarp
Copy link
Member

NRI release notes are usually generated by GitHub's automatic release note generation. This is a newer thing that didn't exist when the containerd project started (and didn't exist when @dmcgowan wrote the release-tool). For our less-complicated subprojects like NRI we've generally been fine with the GitHub feature since it is simpler to use. release-tool has some nice advanced features for dealing with dependencies and for labeling which are really useful for the main containerd repository, but aren't as critical here.

@samuelkarp samuelkarp closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants