Fix thread safety issue on mouse move event handling

Signed-off-by: Christian Parpart <[email protected]>

Author: christianparpart

metainfo.xml

@@ -114,6 +114,7 @@
           <li>Fixes `scripts/install-deps.sh` for openSuSE (Tumbleweed) to install the correct dependencies.</li>
           <li>Fixes missing dependencies for release .deb packages (#1397).</li>
           <li>Fixes legacy keyboard input protocol not reporting non-Alt modifier (#1411).</li>
+          <li>Fixes thread safety issue on mouse move event handling (#1444).</li>
           <li>Digitally sign MacOS release binaries using a valid Apple ID.</li>
           <li>Add support for authenticating to SSH servers with a private key without a password and without requesting for one - also allow password retry (#1425).</li>
           <li>Default history limit is now 1000 lines rather than 0 lines.</li>

src/contour/TerminalSession.cpp

@@ -851,8 +851,11 @@ void TerminalSession::sendMouseMoveEvent(vtbackend::Modifiers modifiers,
 
     terminal().tick(steady_clock::now());
 
-    auto constexpr UiHandledHint = false;
-    terminal().sendMouseMoveEvent(modifiers, pos, pixelPosition, UiHandledHint);
+    {
+        auto const lock = std::lock_guard { _terminal };
+        auto constexpr UiHandledHint = false;
+        _terminal.sendMouseMoveEvent(modifiers, pos, pixelPosition, UiHandledHint);
+    }
 
     if (pos != _currentMousePosition)
     {