Filter processing should not ask for values of whole form

Author: vvoody-

src/DataGrid.php

@@ -1498,11 +1498,6 @@ public function filterSucceeded(NetteForm $form): void
 			return;
 		}
 
-		$values = (array) $form->getUnsafeValues(null, [
-			$form['perPage'],
-			$form['filter'],
-		]);
-
 		if ($this->getPresenterInstance()->isAjax()) {
 			if (isset($form['group_action']['submit']) && $form['group_action']['submit']->isSubmittedBy()) {
 				return;
@@ -1512,9 +1507,11 @@ public function filterSucceeded(NetteForm $form): void
 		/**
 		 * Per page
 		 */
-		if (isset($values['perPage'])) {
-			$this->saveSessionData('_grid_perPage', $values['perPage']);
-			$this->perPage = $values['perPage'];
+		$perPage = $form['perPage']->getValue();
+
+		if (isset($perPage)) {
+			$this->saveSessionData('_grid_perPage', $perPage);
+			$this->perPage = $perPage;
 		}
 
 		/**
@@ -1541,7 +1538,7 @@ public function filterSucceeded(NetteForm $form): void
 				$primaryWhereColumn = $form->getHttpData(Form::DATA_LINE, 'inline_edit[_primary_where_column]');
 
 				if ($edit['submit']->isSubmittedBy() && $edit->getErrors() === []) {
-					$this->inlineEdit->onSubmit($id, $form['inline_edit']->getUnsafeValues(null));
+					$this->inlineEdit->onSubmit($id, $form['inline_edit']->getValues());
 					$this->getPresenterInstance()->payload->_datagrid_inline_edited = $id;
 					$this->getPresenterInstance()->payload->_datagrid_name = $this->getFullName();
 				} else {
@@ -1583,7 +1580,7 @@ public function filterSucceeded(NetteForm $form): void
 
 			if ($add['submit']->isSubmittedBy() || $add['cancel']->isSubmittedBy()) {
 				if ($add['submit']->isSubmittedBy() && $add->getErrors() === []) {
-					$this->inlineAdd->onSubmit($form['inline_add']->getUnsafeValues(null));
+					$this->inlineAdd->onSubmit($form['inline_add']->getValues());
 				}
 
 				$this->redrawControl('tbody');
@@ -1597,7 +1594,7 @@ public function filterSucceeded(NetteForm $form): void
 		/**
 		 * Filter itself
 		 */
-		$values = $values['filter'];
+		$values = $form['filter']->getValues();;
 
 		if (!$values instanceof ArrayHash) {
 			throw new \UnexpectedValueException;

tests/Cases/FilterTest.phpt

@@ -7,9 +7,11 @@ namespace Ublaboo\DataGrid\Tests\Cases;
 require __DIR__ . '/../bootstrap.php';
 
 use Nette\Application\AbortException;
+use Nette\Forms\Container;
 use Tester\Assert;
 use Tester\TestCase;
 use Ublaboo\DataGrid\DataGrid;
+use Ublaboo\DataGrid\Tests\Files\FormValueObject;
 use Ublaboo\DataGrid\Tests\Files\TestingDataGridFactoryRouter;
 
 final class FilterTest extends TestCase
@@ -27,6 +29,39 @@ final class FilterTest extends TestCase
 		}, AbortException::class);
 	}
 
+
+	/**
+	 * This case is testing grid filter processing to not cause side effects by unnecessarily instantiating
+	 * value object {@see FormValueObject} of inline add form container. This value object is crafted
+	 * to fail on constructor argument type check due to inline add form container not being validated in this case.
+	 */
+	public function testFilterSubmitWithInvalidInlineAddOpen(): void
+	{
+		$factory = new TestingDataGridFactoryRouter();
+		/** @var DataGrid $grid */
+		$grid = $factory->createTestingDataGrid()->getComponent('grid');
+
+		$grid->addColumnText('status', 'Status');
+
+		$grid->addInlineAdd()->onControlAdd[] = function (Container $container) {
+			$container->setMappedType(FormValueObject::class);
+			$container->addSelect('status', '', [
+				// items are irrelevant, case is testing control returning null value
+				1 => 'Concept',
+				2 => 'Active',
+				3 => 'Unpublished',
+			])
+				->setPrompt('---')
+				->setRequired();
+		};
+
+		$filterForm = $grid->createComponentFilter();
+
+		Assert::exception(function() use ($grid, $filterForm): void {
+			$grid->filterSucceeded($filterForm);
+		}, AbortException::class);
+	}
+
 }
 
 (new FilterTest)->run();

tests/Files/FormValueObject.php

@@ -0,0 +1,23 @@
+<?php
+declare(strict_types=1);
+
+namespace Ublaboo\DataGrid\Tests\Files;
+
+class FormValueObject
+{
+
+	private $status;
+
+
+	public function __construct(int $status)
+	{
+		$this->status = $status;
+	}
+
+
+	public function getStatus(): int
+	{
+		return $this->status;
+	}
+
+}

tests/Files/TestingDataGridFactoryRouter.php

@@ -16,15 +16,15 @@
 class TestingDataGridFactoryRouter
 {
 
-	public function createTestingDataGrid(): ?IComponent
+	public function createTestingDataGrid(?array $post = null): ?IComponent
 	{
 		$presenterFactory = new PresenterFactory();
 		$presenterFactory->setMapping(['*' => 'Ublaboo\DataGrid\Tests\Files\*Presenter']);
 
 		$presenter = $presenterFactory->createPresenter('Test');
 
 		$url = new UrlScript('http://localhost/index.php');
-		$request = new HttpRequest($url);
+		$request = new HttpRequest($url, $post);
 		$response = new Response();
 		$session = new Session($request, $response);