Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch from chalk to styleText (node:util) #4008

Open
4 tasks
escapedcat opened this issue Apr 5, 2024 · 4 comments
Open
4 tasks

refactor: switch from chalk to styleText (node:util) #4008

escapedcat opened this issue Apr 5, 2024 · 4 comments

Comments

@escapedcat
Copy link
Member

Expected Behavior

Colors should work like before in the terminal but without an extra dependency

Packages using this dep:

  • cz-commitlint
  • format
  • load
  • prompt
  • types

Current Behavior

https://github.com/chalk/chalk is being used

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

No response

Context

https://twitter.com/sitnikcode/status/1776162867907015023

@letsaguiar
Copy link

Since styleText is a feature added in node version 21.7.0 this introduces a breaking change, right?

@escapedcat
Copy link
Member Author

@letsaguiar ah thanks! I just saw the tweet but didn't check which version is needed.
In this case this issue should wait till

  1. Version 22 is out
  2. We have a better reason for a breaking change

@knocte
Copy link
Contributor

knocte commented Apr 8, 2024

Version 22 is out

If you raise the node version requirement to 22, then you break compatibility with Ubuntu LTS.

@escapedcat
Copy link
Member Author

Yeah, this is something for the future. Wouldn't want to break anything because of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants