fix: Find Up dependancy

[Joanneyoung01]

Steps to Reproduce

1. First step
When using commitlint, I have used a conventional commit
2. Second step
Unable to commit due to the current behaviour

Current Behavior

Seeing the below error message

import { findUp } from ‘find-up’;
^^^^^^
SyntaxError: Named export ‘findUp’ not found. The requested module ‘find-up’ is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:
import pkg from ‘find-up’;
const { findUp } = pkg;

Expected Behavior

I should be able to commit correctly

Affected packages

• cli
• core
• prompt
• config-angular

Possible Solution

I have added Find Up as a dependancy

"dependencies": {
"find-up": "^7.0.0"
}

Context

I would like to be able to remove this dependancy as it's a direct dependancy of the Commit Lint package, not required by my application

commitlint --version

@commitlint/cli": "^19.5.0"

git --version

git version 2.47.1

node --version

v20.9.0

[escapedcat]

Can you create a minimal repo for reproduction?
Seems like #4208 was added by mistake and can be closed?

[iamfj]

Just reproduced the same issue. The workaround @Joanneyoung01 mentioned does not worked for me worked and is also not ideal in my opinion.

Packages Used

"devDependencies": {
  (...)
  "@commitlint/cli": "19.6.1",
  "@commitlint/config-conventional": "19.6.0",
  (...)
}

Log

file:///workspaces/***/node_modules/find-up/index.js:2
import {locatePath, locatePathSync} from 'locate-path';
        ^^^^^^^^^^
SyntaxError: Named export 'locatePath' not found. The requested module 'locate-path' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'locate-path';
const {locatePath, locatePathSync} = pkg;

    at ModuleJob._instantiate (node:internal/modules/esm/module_job:134:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:217:5)
    at async ModuleLoader.import (node:internal/modules/esm/loader:316:24)
    at async asyncRunEntryPointWithESMLoader (node:internal/modules/run_main:123:5)

Node.js v20.13.1

Workaround

The workaround i chose is going back to the following versions.

"devDependencies": {
  (...)
  "@commitlint/cli": "18.6.1",
  "@commitlint/config-conventional": "18.6.3",
  (...)
}

[janbiasi]

I'm unable to reproduce this issue with NPM, Yarn and PNPM with Node.js 20 and 22 - tested with 19.6.0 as well as 19.7.1.

commitlint.config.js

export default {
  extends: ["@commitlint/config-conventional"],
  rules: {
    "subject-empty": [2, "always"],
  },
};

package.json

{
  "type": "module",
  "name": "commitlint-repro",
  "version": "1.0.0",
  "scripts": {
    "test": "echo \"test: example commit\" | commitlint "
  },
  "devDependencies": {
    "@commitlint/cli": "19.6.0",
    "@commitlint/config-conventional": "19.6.0"
  }
}

Test result:

> echo "test: example commit" | commitlint

⧗   input: test: example commit
✖   subject must be empty [subject-empty]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@iamfj could you please provide a repro repository for this issue for further investigation?