New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the Wormhole burn address generation description in spec #2

Open

imaginaryusername opened this issue Oct 6, 2018 · 0 comments

imaginaryusername commented Oct 6, 2018

Per the genburn code at https://github.com/copernet/genburn/blob/master/cashaddr_test.go, the criteria for burn address selection seems to be that it must end with "8whc" preceded by 0-9, a stricter criteria than described in the spec (https://github.com/copernet/spec/blob/master/wormhole-burn-addr.pdf) where only "ending in whc" is required. The final generated wormhole burn address agrees with the code instead of the spec. Please fix the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment