Skip to content
This repository was archived by the owner on Mar 25, 2026. It is now read-only.

Commit 5be7430

Browse files
Copilotedburns
andcommitted
Fix: use correct permission denial kind in executePermissionAndRespondAsync
The v3 CLI (1.0.3-0) does not recognize "denied-could-not-request-from-user" as a valid permission result kind. Use the correct constant PermissionRequestResultKind.DENIED_COULD_NOT_REQUEST_FROM_USER which maps to "denied-no-approval-rule-and-could-not-request-from-user". This fixes the CI failures in: - PermissionsTest.testShouldHandlePermissionHandlerErrorsGracefully - ErrorHandlingTest.testShouldHandlePermissionHandlerErrorsGracefully_deniesPermission Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
1 parent 1701918 commit 5be7430

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/main/java/com/github/copilot/sdk/CopilotSession.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import com.github.copilot.sdk.json.PermissionInvocation;
4141
import com.github.copilot.sdk.json.PermissionRequest;
4242
import com.github.copilot.sdk.json.PermissionRequestResult;
43+
import com.github.copilot.sdk.json.PermissionRequestResultKind;
4344
import com.github.copilot.sdk.json.PostToolUseHookInput;
4445
import com.github.copilot.sdk.json.PreToolUseHookInput;
4546
import com.github.copilot.sdk.json.SendMessageRequest;
@@ -716,7 +717,7 @@ private void executePermissionAndRespondAsync(String requestId, PermissionReques
716717
}).exceptionally(ex -> {
717718
try {
718719
PermissionRequestResult denied = new PermissionRequestResult();
719-
denied.setKind("denied-could-not-request-from-user");
720+
denied.setKind(PermissionRequestResultKind.DENIED_COULD_NOT_REQUEST_FROM_USER);
720721
rpc.invoke("session.permissions.handlePendingPermissionRequest",
721722
Map.of("sessionId", sessionId, "requestId", requestId, "result", denied), Object.class);
722723
} catch (Exception e) {
@@ -728,7 +729,7 @@ private void executePermissionAndRespondAsync(String requestId, PermissionReques
728729
LOG.log(Level.WARNING, "Error executing permission handler for requestId=" + requestId, e);
729730
try {
730731
PermissionRequestResult denied = new PermissionRequestResult();
731-
denied.setKind("denied-could-not-request-from-user");
732+
denied.setKind(PermissionRequestResultKind.DENIED_COULD_NOT_REQUEST_FROM_USER);
732733
rpc.invoke("session.permissions.handlePendingPermissionRequest",
733734
Map.of("sessionId", sessionId, "requestId", requestId, "result", denied), Object.class);
734735
} catch (Exception sendEx) {

0 commit comments

Comments
 (0)