Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the templates w.r.t. the coq→rocq renaming ? #134

Open
erikmd opened this issue Feb 9, 2025 · 3 comments
Open

Update the templates w.r.t. the coq→rocq renaming ? #134

erikmd opened this issue Feb 9, 2025 · 3 comments
Labels
enhancement New feature or request

Comments

@erikmd
Copy link
Member

erikmd commented Feb 9, 2025

At first sight, regarding the Docker-Rocq part:

one would need to add in the docker-action.yml.mustache something like:

{{# tested_rocq_opam_versions }}
          - '{{ repo }}{{^ repo }}rocq/rocq-prover{{/ repo }}:{{ version }}'
{{/ tested_rocq_opam_versions }}
@erikmd erikmd added the enhancement New feature or request label Feb 9, 2025
@Zimmi48
Copy link
Member

Zimmi48 commented Feb 10, 2025

So IIUC, we would have a tested_coq_opam_version and a tested_rocq_opam_version?

@palmskog
Copy link
Member

Yes, I think it makes sense to have both, since projects can be compatible with both, e.g., Coq 8.20 and Rocq 9.0.

It's already now possible to add rocq images under the tested_coq_opam_version, but this proposed addition would allow writing things like:

tested_rocq_opam_versions:
- version: '9.0'

which doesn't require knowledge about the exact Docker Hub repo.

@palmskog
Copy link
Member

@erikmd feel free to make a PR and we can very likely merge it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants