Skip to content

Commit 140e285

Browse files
committed
fix(CModal): remove click outside listener when the modal is not visible; fire handleClickOutside method on mouseup event not click
1 parent 7dd7f20 commit 140e285

File tree

1 file changed

+5
-3
lines changed
  • packages/coreui-react/src/components/modal

1 file changed

+5
-3
lines changed

packages/coreui-react/src/components/modal/CModal.tsx

+5-3
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,13 @@ export const CModal = forwardRef<HTMLDivElement, CModalProps>(
128128
}, [visible])
129129

130130
useEffect(() => {
131-
document.addEventListener('click', handleClickOutside)
132-
document.addEventListener('keydown', handleKeyDown)
131+
if (_visible) {
132+
document.addEventListener('mouseup', handleClickOutside)
133+
document.addEventListener('keydown', handleKeyDown)
134+
}
133135

134136
return () => {
135-
document.removeEventListener('click', handleClickOutside)
137+
document.removeEventListener('mouseup', handleClickOutside)
136138
document.removeEventListener('keydown', handleKeyDown)
137139
}
138140
}, [_visible])

0 commit comments

Comments
 (0)