Skip to content

Commit f499b0a

Browse files
authored
Merge pull request #88 from corva-ai/fix/DRE-875_better_merge_events_handling
DRE-875 | Removing misleading validation for partial re-run version
2 parents e5818b5 + adf7904 commit f499b0a

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

77
## [Unreleased]
8+
### Fixed
9+
- Now "version" field represents not schema version but rather the version of rerun and can be any integer.
810

911

1012
## [1.11.3] - 2024-02-07

src/corva/models/merge/raw.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,7 @@ class RawPartialMergeEventData(pydantic.BaseModel):
1717
rerun_asset_id: int
1818
app_stream_id: int
1919
rerun_app_stream_id: int
20-
version: int = pydantic.Field(
21-
..., le=1, ge=1
22-
) # Currently handler supports only 1-st version of this event.
20+
version: int # Partial re-run version
2321
app_id: Optional[int]
2422
app_key: Optional[str]
2523
app_connection_id: int

tests/unit/test_partial_rerun_merge_app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"rerun_asset_id": 2323245,
2121
"app_stream_id": 9585,
2222
"rerun_app_stream_id": 4745,
23-
"version": 1,
23+
"version": 2, # That is the partial re-run version, not schema version.
2424
"app_id": 46,
2525
"app_key": "corva.enrichment-wrapper",
2626
"app_connection_id": 2457,

0 commit comments

Comments
 (0)