@@ -493,7 +493,7 @@ func (suite *KeeperTestSuite) TestRecvPacket() {
493
493
func (suite * KeeperTestSuite ) TestWriteAcknowledgement () {
494
494
var (
495
495
path * ibctesting.Path
496
- ack [] byte
496
+ ack exported. Acknowledgement
497
497
packet exported.PacketI
498
498
channelCap * capabilitytypes.Capability
499
499
)
@@ -504,7 +504,7 @@ func (suite *KeeperTestSuite) TestWriteAcknowledgement() {
504
504
func () {
505
505
suite .coordinator .Setup (path )
506
506
packet = types .NewPacket (ibctesting .MockPacketData , 1 , path .EndpointA .ChannelConfig .PortID , path .EndpointA .ChannelID , path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID , timeoutHeight , disabledTimeoutTimestamp )
507
- ack = ibctesting .MockAcknowledgement
507
+ ack = ibcmock .MockAcknowledgement
508
508
channelCap = suite .chainB .GetChannelCapability (path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID )
509
509
},
510
510
true ,
@@ -513,13 +513,13 @@ func (suite *KeeperTestSuite) TestWriteAcknowledgement() {
513
513
// use wrong channel naming
514
514
suite .coordinator .Setup (path )
515
515
packet = types .NewPacket (ibctesting .MockPacketData , 1 , path .EndpointA .ChannelConfig .PortID , path .EndpointA .ChannelID , ibctesting .InvalidID , ibctesting .InvalidID , timeoutHeight , disabledTimeoutTimestamp )
516
- ack = ibctesting .MockAcknowledgement
516
+ ack = ibcmock .MockAcknowledgement
517
517
channelCap = suite .chainB .GetChannelCapability (path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID )
518
518
}, false },
519
519
{"channel not open" , func () {
520
520
suite .coordinator .Setup (path )
521
521
packet = types .NewPacket (ibctesting .MockPacketData , 1 , path .EndpointA .ChannelConfig .PortID , path .EndpointA .ChannelID , path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID , timeoutHeight , disabledTimeoutTimestamp )
522
- ack = ibctesting .MockAcknowledgement
522
+ ack = ibcmock .MockAcknowledgement
523
523
524
524
err := path .EndpointB .SetChannelClosed ()
525
525
suite .Require ().NoError (err )
@@ -530,7 +530,7 @@ func (suite *KeeperTestSuite) TestWriteAcknowledgement() {
530
530
func () {
531
531
suite .coordinator .Setup (path )
532
532
packet = types .NewPacket (ibctesting .MockPacketData , 1 , path .EndpointA .ChannelConfig .PortID , path .EndpointA .ChannelID , path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID , timeoutHeight , disabledTimeoutTimestamp )
533
- ack = ibctesting .MockAcknowledgement
533
+ ack = ibcmock .MockAcknowledgement
534
534
channelCap = capabilitytypes .NewCapability (3 )
535
535
},
536
536
false ,
@@ -540,14 +540,24 @@ func (suite *KeeperTestSuite) TestWriteAcknowledgement() {
540
540
func () {
541
541
suite .coordinator .Setup (path )
542
542
packet = types .NewPacket (ibctesting .MockPacketData , 1 , path .EndpointA .ChannelConfig .PortID , path .EndpointA .ChannelID , path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID , timeoutHeight , disabledTimeoutTimestamp )
543
- ack = ibctesting .MockAcknowledgement
544
- suite .chainB .App .GetIBCKeeper ().ChannelKeeper .SetPacketAcknowledgement (suite .chainB .GetContext (), packet .GetDestPort (), packet .GetDestChannel (), packet .GetSequence (), ack )
543
+ ack = ibcmock .MockAcknowledgement
544
+ suite .chainB .App .GetIBCKeeper ().ChannelKeeper .SetPacketAcknowledgement (suite .chainB .GetContext (), packet .GetDestPort (), packet .GetDestChannel (), packet .GetSequence (), ack . Acknowledgement () )
545
545
channelCap = suite .chainB .GetChannelCapability (path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID )
546
546
},
547
547
false ,
548
548
},
549
549
{
550
550
"empty acknowledgement" ,
551
+ func () {
552
+ suite .coordinator .Setup (path )
553
+ packet = types .NewPacket (ibctesting .MockPacketData , 1 , path .EndpointA .ChannelConfig .PortID , path .EndpointA .ChannelID , path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID , timeoutHeight , disabledTimeoutTimestamp )
554
+ ack = ibcmock .NewMockEmptyAcknowledgement ()
555
+ channelCap = suite .chainB .GetChannelCapability (path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID )
556
+ },
557
+ false ,
558
+ },
559
+ {
560
+ "acknowledgement is nil" ,
551
561
func () {
552
562
suite .coordinator .Setup (path )
553
563
packet = types .NewPacket (ibctesting .MockPacketData , 1 , path .EndpointA .ChannelConfig .PortID , path .EndpointA .ChannelID , path .EndpointB .ChannelConfig .PortID , path .EndpointB .ChannelID , timeoutHeight , disabledTimeoutTimestamp )
0 commit comments