fix broken links (#415)

* fix for a large portion of the broken links and adding config file for the markdown link checker

* modify link checker yaml to use config file

* fix link checker yaml

* fix some more links and the path to the config file for the markdown link checker

* fix some more dead links

* tweak markdown link checker configuration and remove deprecated section from docs

* address review comments

* fix url for png

Co-authored-by: Carlos Rodriguez <[email protected]>

Author: crodriguezvega

.github/workflows/link-check-config.json

@@ -0,0 +1,10 @@
+{
+  "ignorePatterns": [
+    {
+      "pattern": "(localhost)"
+    }
+  ],
+  "retryOn429": true,
+  "retryCount": 3,
+  "fallbackRetryDelay": "10s"
+}

.github/workflows/link-check.yml

@@ -5,4 +5,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
-    - uses: gaurav-nelson/github-action-markdown-link-check@v1
+    - uses: gaurav-nelson/github-action-markdown-link-check@v1
+      with:
+        config-file: '.github/workflows/link-check-config.json'

CHANGELOG.md

@@ -120,7 +120,7 @@ The IBC module was originally released in [v0.40.0](https://github.com/cosmos/co
 Please see the [Release Notes](https://github.com/cosmos/cosmos-sdk/blob/v0.40.0/RELEASE_NOTES.md).
 
 The IBC module is also contained in the releases for [v0.41.x](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.41.0) and [v0.42.x](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.42.0).
-Please see the Release Notes for [v0.41.x](https://github.com/cosmos/cosmos-sdk/blob/release/v0.41.x/RELEASE_NOTES.md) and [v0.42.x](https://github.com/cosmos/cosmos-sdk/blob/release/v0.42.x/RELEASE_NOTES.md).
+Please see the Release Notes for [v0.41.x](https://github.com/cosmos/cosmos-sdk/blob/v0.41.0/RELEASE_NOTES.md) and [v0.42.x](https://github.com/cosmos/cosmos-sdk/blob/v0.42.0/RELEASE_NOTES.md).
 
 The IBC module was removed in the commit hash [da064e13d56add466548135739c5860a9f7ed842](https://github.com/cosmos/cosmos-sdk/commit/da064e13d56add466548135739c5860a9f7ed842) on the SDK. The release for SDK v0.43.0 will be the first release without the IBC module.
 

SECURITY.md

@@ -1,32 +1,32 @@
 # Security
 
 > **IMPORTANT**: If you find a security issue, you can contact our team directly at
-[email protected], or report it to our [bug bounty program](https://hackerone.com/tendermint) on HackerOne. *DO NOT* open a public issue on the repository.
+[email protected], or report it to our [bug bounty program](https://hackerone.com/cosmos) on HackerOne. *DO NOT* open a public issue on the repository.
 
 ## Bug Bounty
 
 As part of our [Coordinated Vulnerability Disclosure Policy](https://tendermint.com/security), we operate a
-[bug bounty program](https://hackerone.com/tendermint) with Hacker One.
+[bug bounty program](https://hackerone.com/cosmos) with Hacker One.
 
 See the policy linked above for more details on submissions and rewards and read
 this [blog post](https://blog.cosmos.network/bug-bounty-program-for-tendermint-cosmos-833c67693586) for the program scope.
 
 The following is a list of examples of the kinds of bugs we're most interested
-in for the IBC Golang repository. Please refer to the corresponding repositories for vulnerabilities on the [Cosmos SDK]((https://github.com/cosmos/cosmos-sdk/blob/master/SECURITY.md)) and [Tendermint](https://github.com/tendermint/tendermint/blob/master/SECURITY.md) repositories.
+in for the IBC Golang repository. Please refer to the corresponding repositories for vulnerabilities on the [Cosmos SDK](https://github.com/cosmos/cosmos-sdk/blob/master/SECURITY.md) and [Tendermint](https://github.com/tendermint/tendermint/blob/master/SECURITY.md) repositories.
 
 ### IBC Core
 
-- [`02-client`](https://github.com/cosmos/ibc-go/tree/modules/core/02-client)
-- [`03-connection`](https://github.com/cosmos/ibc-go/tree/modules/core/03-connection)
-- [`04-channel`](https://github.com/cosmos/ibc-go/tree/modules/core/04-channel)
-- [`05-port`](https://github.com/cosmos/ibc-go/tree/modules/core/05-port)
-- [`23-commitment`](https://github.com/cosmos/ibc-go/tree/modules/core/23-commitment)
-- [`24-host`](https://github.com/cosmos/ibc-go/tree/modules/core/24-host)
+- [`02-client`](https://github.com/cosmos/ibc-go/tree/main/modules/core/02-client)
+- [`03-connection`](https://github.com/cosmos/ibc-go/tree/main/modules/core/03-connection)
+- [`04-channel`](https://github.com/cosmos/ibc-go/tree/main/modules/core/04-channel)
+- [`05-port`](https://github.com/cosmos/ibc-go/tree/main/modules/core/05-port)
+- [`23-commitment`](https://github.com/cosmos/ibc-go/tree/main/modules/core/23-commitment)
+- [`24-host`](https://github.com/cosmos/ibc-go/tree/main/modules/core/24-host)
 
 ### IBC Applications
 
-- [`transfer`](https://github.com/cosmos/ibc-go/tree/modules/apps/transfer)
+- [`transfer`](https://github.com/cosmos/ibc-go/tree/main/modules/apps/transfer)
 
 ### Light Clients
 
-- [`07-tendermint`](https://github.com/cosmos/ibc-go/tree/modules/light-clients/07-tendermint)
+- [`07-tendermint`](https://github.com/cosmos/ibc-go/tree/main/modules/light-clients/07-tendermint)

docs/DOCS_README.md

@@ -10,7 +10,7 @@ If you want to update the documentation please open a pr on ibc-go.
 
 ## Docs Build Workflow
 
-The documentation for the Cosmos SDK is hosted at https://ibc.cosmos.network/
+The documentation for IBC-Go is hosted at https://ibc.cosmos.network.
 
 built from the files in this (`/docs`) directory for
 [main](https://github.com/cosmos/ibc-go/tree/main/docs).
@@ -87,16 +87,6 @@ Run `pre` and `post` hooks and start a hot-reloading web-server. See output of t
 
 To build documentation as a static website run `npm run build`. You will find the website in `.vuepress/dist` directory.
 
-## Build RPC Docs
-
-TODO: is this still true?
-
-First, run `make tools` from the root of repo, to install the swagger-ui tool.
-
-Then, edit the `swagger.yaml` manually; it is found [here](https://github.com/cosmos/cosmos-sdk/blob/master/client/lcd/swagger-ui/swagger.yaml)
-
-Finally, run `make update_gaia_lite_docs` from the root of the repo.
-
 ## Search
 
 TODO: update or remove

docs/OLD_README.md

@@ -5,6 +5,7 @@ parent:
   title: "ibc"
 -->
 
+<!-- markdown-link-check-disable -->
 # `ibc`
 
 ## Abstract
@@ -113,3 +114,4 @@ x/ibc
 │   └── 09-localhost/
 └── testing/
 ```
+<!-- markdown-link-check-enable-->

docs/architecture/adr-001-coin-source-tracing.md

@@ -12,7 +12,7 @@ Accepted, Implemented
 ## Context
 
 The specification for IBC cross-chain fungible token transfers
-([ICS20](https://github.com/cosmos/ics/tree/master/spec/ics-020-fungible-token-transfer)), needs to
+([ICS20](https://github.com/cosmos/ibc/tree/master/spec/app/ics-020-fungible-token-transfer)), needs to
 be aware of the origin of any token denomination in order to relay a `Packet` which contains the sender
 and recipient addressed in the
 [`FungibleTokenPacketData`](https://github.com/cosmos/ibc/tree/master/spec/app/ics-020-fungible-token-transfer#data-structures).
@@ -199,7 +199,7 @@ func (msg MsgTransfer) ValidateBasic() error {
 // ValidateIBCDenom validates that the given denomination is either:
 //
 //  - A valid base denomination (eg: 'uatom')
-//  - A valid fungible token representation (i.e 'ibc/{hash}') per ADR 001 https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/adr-001-coin-source-tracing.md
+//  - A valid fungible token representation (i.e 'ibc/{hash}') per ADR 001 https://github.com/cosmos/ibc-go/blob/main/docs/architecture/adr-001-coin-source-tracing.md
 func ValidateIBCDenom(denom string) error {
   denomSplit := strings.SplitN(denom, "/", 2)
 

docs/architecture/adr-015-ibc-packet-receiver.md

@@ -296,4 +296,4 @@ Proposed
 ## References
 
 - Relevant comment: [cosmos/ics#289](https://github.com/cosmos/ics/issues/289#issuecomment-544533583)
-- [ICS26 - Routing Module](https://github.com/cosmos/ics/blob/master/spec/ics-026-routing-module)
+- [ICS26 - Routing Module](https://github.com/cosmos/ibc/tree/master/spec/core/ics-026-routing-module)

docs/ibc/apps.md

@@ -7,7 +7,7 @@ order: 3
 Learn how to configure your application to use IBC and send data packets to other chains. {synopsis}
 
 This document serves as a guide for developers who want to write their own Inter-blockchain
-Communication Protocol (IBC) applications for custom [use-cases](https://github.com/cosmos/ics/blob/master/ibc/4_IBC_USECASES.md).
+Communication Protocol (IBC) applications for custom use cases.
 
 Due to the modular design of the IBC protocol, IBC
 application developers do not need to concern themselves with the low-level details of clients,
@@ -255,7 +255,7 @@ to implement callbacks for handling the packet flow through a channel.
 Once a module A and module B are connected to each other, relayers can start relaying packets and
 acknowledgements back and forth on the channel.
 
-![IBC packet flow diagram](https://media.githubusercontent.com/media/cosmos/ics/master/spec/ics-004-channel-and-packet-semantics/packet-state-machine.png)
+![IBC packet flow diagram](https://media.githubusercontent.com/media/cosmos/ibc/old/spec/ics-004-channel-and-packet-semantics/channel-state-machine.png)
 
 Briefly, a successful packet flow works as follows:
 
@@ -353,7 +353,7 @@ receive acknowledegments with the IBC modules as byte strings.
 
 Thus, modules must agree on how to encode/decode acknowledgements. The process of creating an
 acknowledgement struct along with encoding and decoding it, is very similar to the packet data
-example above. [ICS 04](https://github.com/cosmos/ics/tree/master/spec/ics-004-channel-and-packet-semantics#acknowledgement-envelope)
+example above. [ICS 04](https://github.com/cosmos/ibc/blob/master/spec/core/ics-004-channel-and-packet-semantics#acknowledgement-envelope)
 specifies a recommended format for acknowledgements. This acknowledgement type can be imported from
 [channel types](https://github.com/cosmos/ibc-go/tree/main/modules/core/04-channel/types).
 
@@ -366,7 +366,7 @@ While modules may choose arbitrary acknowledgement structs, a default acknowledg
 // conflicts with other protobuf message formats used for acknowledgements.
 // The first byte of any message with this format will be the non-ASCII values
 // `0xaa` (result) or `0xb2` (error). Implemented as defined by ICS:
-// https://github.com/cosmos/ics/tree/master/spec/ics-004-channel-and-packet-semantics#acknowledgement-envelope
+// https://github.com/cosmos/ibc/tree/master/spec/core/ics-004-channel-and-packet-semantics#acknowledgement-envelope
 message Acknowledgement {
   // response contains either a result or an error and must be non-empty
   oneof response {

docs/ibc/integration.md

@@ -178,7 +178,7 @@ connection handhake.
 The IBC module also has
 [`BeginBlock`](https://github.com/cosmos/ibc-go/blob/main/modules/core/02-client/abci.go) logic as
 well. This is optional as it is only required if your application uses the [localhost
-client](https://github.com/cosmos/ics/blob/master/spec/ics-009-loopback-client) to connect two
+client](https://github.com/cosmos/ibc/blob/master/spec/client/ics-009-loopback-client) to connect two
 different modules from the same chain.
 
 ::: tip

docs/ibc/overview.md

@@ -11,7 +11,7 @@ Learn what IBC is, its components and use cases. {synopsis}
 ## What is the Interblockchain Communication Protocol (IBC)?
 
 This document serves as a guide for developers who want to write their own Inter-blockchain
-Communication Protocol (IBC) applications for custom [use-cases](https://github.com/cosmos/ics/blob/master/ibc/4_IBC_USECASES.md).
+Communication Protocol (IBC) applications for custom use cases.
 
 Due to the modular design of the IBC protocol, IBC
 application developers do not need to concern themselves with the low-level details of clients,
@@ -61,12 +61,12 @@ must use for committing IBC messages is defined in
 [ICS-24](https://github.com/cosmos/ics/tree/master/spec/core/ics-024-host-requirements) and the proof
 format that all implementations must be able to produce and verify is defined in this [ICS-23 implementation](https://github.com/confio/ics23).
 
-### [Capabilities](./ocap.md)
+### [Capabilities](https://github.com/cosmos/cosmos-sdk/blob/master/docs/core/ocap.md)
 
 IBC is intended to work in execution environements where modules do not necessarily trust each
 other. Thus IBC must authenticate module actions on ports and channels so that only modules with the
 appropriate permissions can use them. This is accomplished using [dynamic
-capabilities](../architecture/adr-003-dynamic-capability-store.md). Upon binding to a port or
+capabilities](https://github.com/cosmos/cosmos-sdk/blob/master/docs/architecture/adr-003-dynamic-capability-store.md). Upon binding to a port or
 creating a channel for a module, IBC will return a dynamic capability that the module must claim in
 order to use that port or channel. This prevents other modules from using that port or channel since
 they will not own the appropriate capability.
@@ -175,8 +175,8 @@ Once an acknowledgement is received successfully on the original sender the chai
 
 If you want to learn more about IBC, check the following specifications:
 
-* [IBC specification overview](https://github.com/cosmos/ics/blob/master/ibc/README.md)
-* [IBC SDK specification](../../modules/ibc)
+* [IBC specification overview](https://github.com/cosmos/ibc/blob/master/README.md)
+* [IBC SDK specification](../../modules/core/spec/README.md)
 
 ## Next {hide}
 

docs/ibc/proto-docs.md

@@ -616,7 +616,7 @@ upgrade.
 ### MsgTransfer
 MsgTransfer defines a msg to transfer fungible tokens (i.e Coins) between
 ICS20 enabled chains. See ICS Spec here:
-https://github.com/cosmos/ics/tree/master/spec/ics-020-fungible-token-transfer#data-structures
+https://github.com/cosmos/ibc/tree/master/spec/app/ics-020-fungible-token-transfer#data-structures
 
 
 | Field | Type | Label | Description |
@@ -675,7 +675,7 @@ Msg defines the ibc/transfer Msg service.
 ### FungibleTokenPacketData
 FungibleTokenPacketData defines a struct for the packet payload
 See FungibleTokenPacketData spec:
-https://github.com/cosmos/ics/tree/master/spec/ics-020-fungible-token-transfer#data-structures
+https://github.com/cosmos/ibc/tree/master/spec/app/ics-020-fungible-token-transfer#data-structures
 
 
 | Field | Type | Label | Description |
@@ -715,7 +715,7 @@ NOTE: The field numbers 21 and 22 were explicitly chosen to avoid accidental
 conflicts with other protobuf message formats used for acknowledgements.
 The first byte of any message with this format will be the non-ASCII values
 `0xaa` (result) or `0xb2` (error). Implemented as defined by ICS:
-https://github.com/cosmos/ics/tree/master/spec/ics-004-channel-and-packet-semantics#acknowledgement-envelope
+https://github.com/cosmos/ibc/tree/master/spec/core/ics-004-channel-and-packet-semantics#acknowledgement-envelope
 
 
 | Field | Type | Label | Description |

docs/migrations/ibc-migration-043.md

@@ -104,7 +104,7 @@ The IBC Keeper now takes in the Upgrade Keeper. Please add the chains' Upgrade K
 
 ### UpdateClientProposal
 
-The `UpdateClient` has been modified to take in two client-identifiers and one initial height. Please see the [documentation](../proposals.md) for more information. 
+The `UpdateClient` has been modified to take in two client-identifiers and one initial height. Please see the [documentation](../ibc/proposals.md) for more information. 
 
 ### UpgradeProposal
 

modules/apps/transfer/keeper/msg_server.go

@@ -9,7 +9,7 @@ import (
 
 var _ types.MsgServer = Keeper{}
 
-// See createOutgoingPacket in spec:https://github.com/cosmos/ics/tree/master/spec/ics-020-fungible-token-transfer#packet-relay
+// See createOutgoingPacket in spec:https://github.com/cosmos/ibc/tree/master/spec/app/ics-020-fungible-token-transfer#packet-relay
 
 // Transfer defines a rpc handler method for MsgTransfer.
 func (k Keeper) Transfer(goCtx context.Context, msg *types.MsgTransfer) (*types.MsgTransferResponse, error) {

modules/apps/transfer/keeper/relay.go

@@ -81,7 +81,7 @@ func (k Keeper) SendTransfer(
 	}
 
 	// begin createOutgoingPacket logic
-	// See spec for this logic: https://github.com/cosmos/ics/tree/master/spec/ics-020-fungible-token-transfer#packet-relay
+	// See spec for this logic: https://github.com/cosmos/ibc/tree/master/spec/app/ics-020-fungible-token-transfer#packet-relay
 	channelCap, ok := k.scopedKeeper.GetCapability(ctx, host.ChannelCapabilityPath(sourcePort, sourceChannel))
 	if !ok {
 		return sdkerrors.Wrap(channeltypes.ErrChannelCapabilityNotFound, "module does not own channel capability")

modules/apps/transfer/spec/01_concepts.md

@@ -6,7 +6,7 @@ order: 1
 
 ## Acknowledgements
 
-ICS20 uses the recommended acknowledgement format as specified by [ICS 04](https://github.com/cosmos/ics/tree/master/spec/ics-004-channel-and-packet-semantics#acknowledgement-envelope).
+ICS20 uses the recommended acknowledgement format as specified by [ICS 04](https://github.com/cosmos/ibc/tree/master/spec/core/ics-004-channel-and-packet-semantics#acknowledgement-envelope).
 
 A successful receive of a transfer packet will result in a Result Acknowledgement being written
 with the value `[]byte(byte(1))` in the `Response` field.

modules/apps/transfer/spec/02_state.md

@@ -4,7 +4,7 @@ order: 2
 
 # State
 
-The transfer IBC application module keeps state of the port to which the module is binded and the denomination trace information as outlined in [ADR 01](./../../../../../docs/architecture/adr-001-coin-source-tracing.md).
+The transfer IBC application module keeps state of the port to which the module is binded and the denomination trace information as outlined in [ADR 01](./../../../../docs/architecture/adr-001-coin-source-tracing.md).
 
 - `Port`: `0x01 -> ProtocolBuffer(string)`
 - `DenomTrace`: `0x02 | []bytes(traceHash) -> ProtocolBuffer(DenomTrace)`

modules/apps/transfer/spec/04_messages.md

@@ -29,7 +29,7 @@ This message is expected to fail if:
 - `Sender` is empty
 - `Receiver` is empty
 - `TimeoutHeight` and `TimeoutTimestamp` are both zero
-- `Token.Denom` is not a valid IBC denomination as per [ADR 001 - Coin Source Tracing](./../../../../../docs/architecture/adr-001-coin-source-tracing.md).
+- `Token.Denom` is not a valid IBC denomination as per [ADR 001 - Coin Source Tracing](./../../../../docs/architecture/adr-001-coin-source-tracing.md).
 
 This message will send a fungible token to the counterparty chain represented
 by the counterparty Channel End connected to the Channel End with the identifiers

modules/apps/transfer/spec/06_metrics.md

@@ -4,7 +4,7 @@ order: 6
 
 # Metrics
 
-The transfer IBC application module exposes the following set of [metrics](./../../../../../docs/core/telemetry.md).
+The transfer IBC application module exposes the following set of [metrics](https://github.com/cosmos/cosmos-sdk/blob/master/docs/core/telemetry.md).
 
 | Metric                          | Description                                                                               | Unit            | Type    |
 |:--------------------------------|:------------------------------------------------------------------------------------------|:----------------|:--------|

modules/apps/transfer/spec/07_params.md

@@ -17,14 +17,12 @@ The transfers enabled parameter controls send cross-chain transfer capabilities
 tokens.
 
 To prevent a single token from being transferred from the chain, set the `SendEnabled` parameter to `true` and
-then set the bank module's [`SendEnabled` parameter](./../../../../bank/spec/05_params.md#sendenabled) for
-the denomination to `false`.
+then set the bank module's [`SendEnabled` parameter](https://github.com/cosmos/cosmos-sdk/blob/master/x/bank/spec/05_params.md#sendenabled) for the denomination to `false`.
 
 ## ReceiveEnabled
 
 The transfers enabled parameter controls receive cross-chain transfer capabilities for all fungible
 tokens.
 
 To prevent a single token from being transferred to the chain, set the `ReceiveEnabled` parameter to `true` and
-then set the bank module's [`SendEnabled` parameter](./../../../../bank/spec/05_params.md#sendenabled) for
-the denomination to `false`.
+then set the bank module's [`SendEnabled` parameter](https://github.com/cosmos/cosmos-sdk/blob/master/x/bank/spec/05_params.md#sendenabled) for the denomination to `false`.

modules/apps/transfer/spec/README.md

@@ -11,7 +11,7 @@ parent:
 
 This paper defines the implementation of the ICS20 protocol on the Cosmos SDK.
 
-For the general specification please refer to the [ICS20 Specification](https://github.com/cosmos/ics/tree/master/spec/ics-020-fungible-token-transfer).
+For the general specification please refer to the [ICS20 Specification](https://github.com/cosmos/ibc/tree/master/spec/app/ics-020-fungible-token-transfer).
 
 ## Contents