Skip to content

Commit b912bb8

Browse files
committedDec 28, 2022
feat!: Organise SSM paramamters by path (github-aws-runners#2569)
Migration is only required when using pre-build AMI with your tailored start-runner script. Before all parameters were based on convetion. We have update them to be predictable with still similar conventions as default. We set the tag ghr:ssm_config_path as EC2 instance tag to the path used for the configuration. In the config path we store the same values as before (run_as, enable_cloudwatch, agent_mode). The tokens are stored in a separate location which can be retrieved by looking up the value token_path in the config. For a more details example check-out the following diffs: Linux start script // TODO UPDATE AFTER MERGE Windows start script // TODO UPDATE AFTER MERGE
1 parent 0823d47 commit b912bb8

File tree

104 files changed

+1535
-2064
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

104 files changed

+1535
-2064
lines changed
 

Diff for: ‎.github/lint/tflint.tfvars

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
aws_region = null
2+
github_app = {
3+
id = "0"
4+
key_base64 = "0"
5+
webhook_secret = "0"
6+
}
7+
subnet_ids = []
8+
vpc_id = null

Diff for: ‎.github/workflows/terraform.yml

+13
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ on:
77
paths-ignore:
88
- "modules/*/lambdas/**"
99

10+
permissions:
11+
contents: read
12+
pull-requests: write
13+
1014
env:
1115
AWS_REGION: eu-west-1
1216
jobs:
@@ -37,6 +41,14 @@ jobs:
3741
continue-on-error: true
3842
- name: validate terraform
3943
run: terraform validate
44+
- if: contains(matrix.terraform, '1.3.')
45+
name: Setup TFLint
46+
uses: terraform-linters/setup-tflint@v2
47+
with:
48+
github_token: ${{ secrets.GITHUB_TOKEN }}
49+
- if: contains(matrix.terraform, '1.3.')
50+
name: Run TFLint
51+
run: tflint -f compact
4052

4153
verify_examples:
4254
name: Verify examples
@@ -92,3 +104,4 @@ jobs:
92104
continue-on-error: true
93105
- name: validate terraform
94106
run: terraform validate
107+

0 commit comments

Comments
 (0)
Please sign in to comment.