Skip to content

Conversation

@amotl
Copy link
Contributor

@amotl amotl commented Nov 10, 2025

@amotl amotl requested review from matriv and seut November 10, 2025 16:40
@amotl amotl marked this pull request as ready for review November 10, 2025 16:40
@surister
Copy link
Member

Should we perhaps maintain this and check for CrateDB version? I assume that this will break people trying to use it with CrateDB < 6.2

In order to learn more about Singer, Meltano, and friends, navigate to the
[Singer Intro](./docs/singer-intro.md).

Operating the package successfully needs CrateDB 6.2 or higher.
Copy link
Contributor Author

@amotl amotl Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @surister. Thanks. Let me loop your comment into a thread.

Should we perhaps maintain this and check for CrateDB version? I assume that this will break people trying to use it with CrateDB < 6.2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will not work with lower versions of CrateDB. As I see the CrateDB 6.2 release might be far away (expecting 6.1 first?), this patch is probably not ready for releasing, and should be made a draft again?

Copy link
Contributor Author

@amotl amotl Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about pre-flight checks. I haven't seen many (if any) such measures in other vendor's adapters. In a perfect world, this adapter will vanish completely anyway if we could submit all specialities into the upstream target-postgres.

However, I see your point, and, as long as we maintain a separate adapter, and, most importantly, as long as it will not have a negative performance impact in high-traffic or high-volume environments, I will not object adding conveniency features like pre-flight version checks.

Copy link
Contributor Author

@amotl amotl Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch includes a check for the CrateDB version, as suggested.

Copy link
Contributor Author

@amotl amotl Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: The package is in alpha/workbench mode, currently bearing just 46 downloads per month. In this spirit, we can easily produce (merge & release) this improvement, to make it a fully functional and significantly enhanced package for all users of CrateDB nightly and future CrateDB 6.2 users, even if this will only be released in Jan/Feb 2026.

All people who are currently using the package can easily stick with the currently released version. There is not much need to introduce or address backward compatibility issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvalidColumnNameException["_sdc_deleted_at" conflicts with system column pattern]

3 participants