From 98056b485e0edec8d61d65ebc1fb178812148918 Mon Sep 17 00:00:00 2001
From: jeeminso <jeeminso@gmail.com>
Date: Tue, 15 Apr 2025 20:34:12 -0400
Subject: [PATCH] Revert "Test dynamic column names in resultsets"

This reverts commit a5f3a3fd6aaf1f0d30aa7f4eba5630b5a7a9f74a.
---
 tests/bwc/test_upgrade.py | 35 +++++++++++------------------------
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/tests/bwc/test_upgrade.py b/tests/bwc/test_upgrade.py
index eb11fcb5..84bc7282 100644
--- a/tests/bwc/test_upgrade.py
+++ b/tests/bwc/test_upgrade.py
@@ -258,22 +258,20 @@ def _do_upgrade(self,
             assert_busy(lambda: self.assert_green(conn, 'blob', 'b1'))
             self.assertIsNotNone(container.get(digest))
 
-        accumulated_dynamic_column_names: list[str] = []
         self._process_on_stop()
         for version_def in versions[1:]:
             timestamp = datetime.utcnow().isoformat(timespec='seconds')
             print(f"{timestamp} Upgrade to: {version_def.version}")
-            self.assert_data_persistence(version_def, nodes, digest, paths, accumulated_dynamic_column_names)
+            self.assert_data_persistence(version_def, nodes, digest, paths)
         # restart with latest version
         version_def = versions[-1]
-        self.assert_data_persistence(version_def, nodes, digest, paths, accumulated_dynamic_column_names)
+        self.assert_data_persistence(version_def, nodes, digest, paths)
 
     def assert_data_persistence(self,
                                 version_def: VersionDef,
                                 nodes: int,
                                 digest: str,
-                                paths: Iterable[str],
-                                accumulated_dynamic_column_names: list[str]):
+                                paths: Iterable[str]):
         env = prepare_env(version_def.java_home)
         version = version_def.version
         cluster = self._new_cluster(version, nodes, data_paths=paths, settings=self.CLUSTER_SETTINGS, env=env)
@@ -305,26 +303,15 @@ def assert_data_persistence(self,
                 cursor.execute(f'select * from versioned."{table}"')
                 cursor.execute(f'insert into versioned."{table}" (id, col_int) values (?, ?)', [str(uuid4()), 1])
 
-            # to trigger `alter` stmt bug(https://github.com/crate/crate/pull/17178) that falsely updated the table's
-            # version created setting that resulted in oids instead of column names in resultsets
-            cursor.execute('ALTER TABLE doc.parted SET ("refresh_interval" = 900)')
-
             # older versions had a bug that caused this to fail
-            # Test that partition and dynamic columns can be created
-            key = "t_" + version.replace('.', '_')
-            obj = {key: True}
-            args = (str(uuid4()), version, obj)
-            cursor.execute(
-                'INSERT INTO doc.parted (id, version, cols) VALUES (?, ?, ?)',
-                args
-            )
-            cursor.execute('REFRESH TABLE doc.parted')
-            accumulated_dynamic_column_names.append(key)
-            cursor.execute('SELECT cols FROM doc.parted')
-            result = cursor.fetchall()
-            for row in result:
-                for name in row[0].keys():
-                    self.assertIn(name, accumulated_dynamic_column_names)
+            if version in ('latest-nightly', '3.2'):
+                # Test that partition and dynamic columns can be created
+                obj = {"t_" + version.replace('.', '_'): True}
+                args = (str(uuid4()), version, obj)
+                cursor.execute(
+                    'INSERT INTO doc.parted (id, version, cols) values (?, ?, ?)',
+                    args
+                )
         self._process_on_stop()
 
     def assert_green(self, conn: Connection, schema: str, table_name: str):