Skip to content

Commit 9736aaa

Browse files
committed
MOBILE-5105 behat: Escape BEHAT_TAGS
1 parent 7af52dd commit 9736aaa

3 files changed

Lines changed: 15 additions & 12 deletions

File tree

.github/workflows/acceptance.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,13 @@ jobs:
7575
id: set-tags
7676
working-directory: app
7777
run: |
78-
if [ -z $BEHAT_TAGS ]; then
79-
tags_json=`.github/scripts/print_behat_tags_json.sh`
78+
if [ -z "$BEHAT_TAGS" ]; then
79+
tags_json=$(.github/scripts/print_behat_tags_json.sh)
8080
echo "Generated tags: $tags_json"
81-
echo "tags=$tags_json" >> $GITHUB_OUTPUT;
81+
printf 'tags=%s\n' "$tags_json" >> "$GITHUB_OUTPUT"
8282
else
83-
echo "tags=[\"$BEHAT_TAGS\"]" >> $GITHUB_OUTPUT;
83+
tags_json=$(jq -cn --arg tag "$BEHAT_TAGS" '[$tag]')
84+
printf 'tags=%s\n' "$tags_json" >> "$GITHUB_OUTPUT"
8485
fi
8586
env:
8687
BEHAT_TAGS: ${{ github.event.inputs.behat_tags }}

.github/workflows/coverage.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,12 @@ jobs:
6262
id: set-tags
6363
working-directory: app
6464
run: |
65-
if [ -z $BEHAT_TAGS ]; then
66-
tags_json=`.github/scripts/print_behat_tags_json.sh`
67-
echo "tags=$tags_json" >> $GITHUB_OUTPUT;
65+
if [ -z "$BEHAT_TAGS" ]; then
66+
tags_json=$(.github/scripts/print_behat_tags_json.sh)
67+
printf 'tags=%s\n' "$tags_json" >> "$GITHUB_OUTPUT"
6868
else
69-
echo "tags=[\"$BEHAT_TAGS\"]" >> $GITHUB_OUTPUT;
69+
tags_json=$(jq -cn --arg tag "$BEHAT_TAGS" '[$tag]')
70+
printf 'tags=%s\n' "$tags_json" >> "$GITHUB_OUTPUT"
7071
fi
7172
env:
7273
BEHAT_TAGS: ${{ github.event.inputs.behat_tags }}

.github/workflows/update_behat_snapshots.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,12 @@ jobs:
5656
id: set-tags
5757
working-directory: app
5858
run: |
59-
if [ -z $BEHAT_TAGS ]; then
60-
tags_json=`.github/scripts/print_behat_tags_json.sh snapshots`
61-
echo "tags=$tags_json" >> $GITHUB_OUTPUT;
59+
if [ -z "$BEHAT_TAGS" ]; then
60+
tags_json=$(.github/scripts/print_behat_tags_json.sh snapshots)
61+
printf 'tags=%s\n' "$tags_json" >> "$GITHUB_OUTPUT"
6262
else
63-
echo "tags=[\"$BEHAT_TAGS\"]" >> $GITHUB_OUTPUT;
63+
tags_json=$(jq -cn --arg tag "$BEHAT_TAGS" '[$tag]')
64+
printf 'tags=%s\n' "$tags_json" >> "$GITHUB_OUTPUT"
6465
fi
6566
for feature in `find src/ -iname *.feature`
6667
do

0 commit comments

Comments
 (0)