From bf8a06f21af7114d51dab241c44143a0efd599c0 Mon Sep 17 00:00:00 2001 From: crccheck Date: Wed, 6 Aug 2025 06:01:55 +0000 Subject: [PATCH 1/6] remove outdated reference to Black formatting, done by robots now --- CONTRIBUTING.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8d53563..e69de29 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,4 +0,0 @@ -This project uses [Black] to format code. To avoid manually running `black .`, -you can install a Git hook or a format-on-save plugin for your editor. - -[Black]: https://github.com/psf/black From 0673956a434dbc5cede94cc5de62be089cd32828 Mon Sep 17 00:00:00 2001 From: crccheck Date: Wed, 6 Aug 2025 06:02:09 +0000 Subject: [PATCH 2/6] feat(ci): cache pip requirements --- .github/workflows/ci.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0677238..964bb78 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,6 +36,13 @@ jobs: - uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} + - name: Cache pip + uses: actions/cache@v4 + with: + path: ~/.cache/pip + key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ matrix.django-version }} + restore-keys: | + ${{ runner.os }}-pip- - run: pip install -e '.[dev]' - run: pip install "Django==${{ matrix.django-version }}.*" - run: make test From 82379ef943485dbfbf67033e5140598383f7d75c Mon Sep 17 00:00:00 2001 From: crccheck Date: Wed, 6 Aug 2025 06:09:32 +0000 Subject: [PATCH 3/6] combine pip install --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 964bb78..30c24e7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -43,8 +43,7 @@ jobs: key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ matrix.django-version }} restore-keys: | ${{ runner.os }}-pip- - - run: pip install -e '.[dev]' - - run: pip install "Django==${{ matrix.django-version }}.*" + - run: pip install -e '.[dev]' "Django==${{ matrix.django-version }}.*" - run: make test lint: From 202de42137d7a5e35bc22481731642c35311a89b Mon Sep 17 00:00:00 2001 From: crccheck Date: Wed, 6 Aug 2025 06:19:04 +0000 Subject: [PATCH 4/6] feedback: hash deps in pip cache --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 30c24e7..b7b1059 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -40,7 +40,7 @@ jobs: uses: actions/cache@v4 with: path: ~/.cache/pip - key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ matrix.django-version }} + key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ matrix.django-version }}-${{ hashFiles('pyproject.toml') }} restore-keys: | ${{ runner.os }}-pip- - run: pip install -e '.[dev]' "Django==${{ matrix.django-version }}.*" From fe156724bdcf7281e2d5fc11a2d627011b171f9f Mon Sep 17 00:00:00 2001 From: crccheck Date: Mon, 15 Sep 2025 23:03:39 +0000 Subject: [PATCH 5/6] nevermind, caching aint easy --- .github/workflows/ci.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b7b1059..0677238 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,14 +36,8 @@ jobs: - uses: actions/setup-python@v5 with: python-version: ${{ matrix.python-version }} - - name: Cache pip - uses: actions/cache@v4 - with: - path: ~/.cache/pip - key: ${{ runner.os }}-pip-${{ matrix.python-version }}-${{ matrix.django-version }}-${{ hashFiles('pyproject.toml') }} - restore-keys: | - ${{ runner.os }}-pip- - - run: pip install -e '.[dev]' "Django==${{ matrix.django-version }}.*" + - run: pip install -e '.[dev]' + - run: pip install "Django==${{ matrix.django-version }}.*" - run: make test lint: From 58a7e6f38d164adb2ce2f14688084ab347b698d5 Mon Sep 17 00:00:00 2001 From: crccheck Date: Mon, 15 Sep 2025 23:06:54 +0000 Subject: [PATCH 6/6] delint --- django_object_actions/tests/test_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/django_object_actions/tests/test_utils.py b/django_object_actions/tests/test_utils.py index 0df3969..da7a814 100644 --- a/django_object_actions/tests/test_utils.py +++ b/django_object_actions/tests/test_utils.py @@ -76,7 +76,7 @@ def test_get_button_attrs_gets_set(self): def test_get_button_attrs_custom_attrs_get_partitioned(self): mock_tool = type("mock_tool", (object,), {"attrs": {"nonstandard": "wombat"}}) - attrs, custom = self.instance._get_button_attrs(mock_tool) + _attrs, custom = self.instance._get_button_attrs(mock_tool) self.assertEqual(custom["nonstandard"], "wombat")