Skip to content

closes #159 Move information about old GSoC projects to CC Open Source #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Feb 20, 2021

Conversation

Cronus1007
Copy link
Member

@Cronus1007 Cronus1007 commented Dec 15, 2020

Fixes

Fixes #159 by @hugosolar

Description

Adds contents about the old gsoc projects to the website.

Technical details

Just have added a lot of the contents.lr file in relation to close the PR.

Tests

No Tests since my work is related a lot to Front End .

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow [best practices][best_practices].
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
…o CC Open Source
@Cronus1007 Cronus1007 requested review from a team as code owners December 15, 2020 10:05
@Cronus1007 Cronus1007 requested review from dhruvkb, kgodey and mathemancer and removed request for a team December 15, 2020 10:05
@Cronus1007
Copy link
Member Author

@dhruvkb Just a look how I am proceeding for this PR. So let me know the required changes.

@Cronus1007 Cronus1007 marked this pull request as draft December 15, 2020 14:06
@Cronus1007 Cronus1007 marked this pull request as ready for review December 16, 2020 19:15
@Cronus1007 Cronus1007 requested a review from a team as a code owner December 16, 2020 19:15
@Cronus1007
Copy link
Member Author

@dhruvkb @kgodey Getting information about the GSOC-08,07,06 has been very much difficult.

@Cronus1007
Copy link
Member Author

@TimidRobot

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Could use some improvements in terms of punctuation, spelling and grammar. I would recommend setting up Grammarly to help with that.
  2. All the md5_hashed_email fields are identical. If you don't have the email addresses, it would be preferable to leave them blank rather than populate an arbitrary value.
  3. Use the same value for the author username field as the name of the file, for consistency.
  4. I would suggest using this template for the bio:
<full name> ([`@<github handle>`](<github profile link>) on GitHub) was a Google Summer of Code <year> intern with Creative Commons. They developed [<project name>](<project link>) as a part of their internship.

@Cronus1007
Copy link
Member Author

@dhruvkb But for few ones I am unable to find their github profile link. So shall I deleberately mark them as #

@Cronus1007 Cronus1007 requested review from dhruvkb and removed request for a team December 21, 2020 05:15
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old content (before 2019) should be put in content/archives/old-tech-blog instead of content/blog.

@Cronus1007
Copy link
Member Author

@TimidRobot Okk I will soon make the changes. Plzzzz review this PR as well #584

@Cronus1007 Cronus1007 requested a review from TimidRobot January 6, 2021 19:49
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the sources for this information? Did you write new blog posts?

  • Kriti did not work at CC in 2010
  • There are many duplicated sentences
  • While people can technically follow projects at cc-archive, the projects archived there are no longer under development

@Cronus1007
Copy link
Member Author

@TimidRobot The source of the information is cc-archives and gsoc-wiki links given in the website. Yes there are many duplicated sentences which refers Kriti particularly as I found in blog posts of gsoc-2019 students.

@Cronus1007 Cronus1007 requested a review from TimidRobot January 14, 2021 16:53
@TimidRobot TimidRobot self-assigned this Jan 14, 2021
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, great work tracking down the content!!

  • Please update author names
    • author: and directory name should be short/abbreviated
    • username: should be the display name
    • as an example, I updated ethanlim/Ethan Lim
  • Please update the content so that it mirrors the original without any additions or subtractions (ex. Kriti was not a mentor prior to 2019).

@Cronus1007 Cronus1007 requested a review from TimidRobot February 3, 2021 14:16
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cronus1007 This is great work! I really appreciate your diligence and patience.

@TimidRobot TimidRobot merged commit f00763e into creativecommons:master Feb 20, 2021
@Cronus1007 Cronus1007 deleted the move branch February 20, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move information about old GSoC projects to CC Open Source
3 participants