Skip to content

Commit d328b00

Browse files
committed
fix unit test
1 parent f61de3d commit d328b00

File tree

7 files changed

+20
-9
lines changed

7 files changed

+20
-9
lines changed

.psh.yaml.dist

+4-1
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,7 @@ dynamic:
88
environments:
99
docker:
1010
paths:
11-
- "dev-ops/docker/actions"
11+
- "dev-ops/docker/actions"
12+
travis:
13+
paths:
14+
- "dev-ops/travis/actions"

.travis.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ install:
1111
- composer install
1212

1313
script:
14-
- ./tools/psh code-style
15-
- ./tools/psh quality
16-
- ./tools/psh unit
14+
- ./tools/psh travis:code-style
15+
- ./tools/psh travis:quality
16+
- ./tools/psh travis:unit
1717

1818
matrix:
1919
allow_failures:

dev-ops/travis/actions/code-style.sh

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#!/usr/bin/env bash
2+
#DESCRIPTION: execute php-cs-fixer
3+
4+
./tools/php-cs-fixer fix --config=.php-cs --dry-run

dev-ops/travis/actions/quality.sh

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#!/usr/bin/env bash
2+
#DESCRIPTION: execute all quality analyzer
3+
4+
INCLUDE: ./../../common/actions/quality.sh

dev-ops/travis/actions/unit.sh

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#!/usr/bin/env bash
2+
#DESCRIPTION: execute phpunit
3+
4+
USERNAME=$USERNAME APIKEY=$APIKEY ./vendor/bin/phpunit --stop-on-failure --stop-on-error --coverage-html=./build/artifacts/html-coverage

phpunit.xml.dist

-4
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,4 @@
1919
<directory>src</directory>
2020
</whitelist>
2121
</filter>
22-
<php>
23-
<env name="USERNAME" value=""/>
24-
<env name="APIKEY" value=""/>
25-
</php>
2622
</phpunit>

src/Estimate/EstimateValidator.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ private function checkItems(EstimateEntity $entity)
9292
$errorMessages[] = $this->estimateItemValidator->validateEstimateItem($item);
9393
}
9494

95-
if (count($errorMessages)) {
95+
if (count($errorMessages) > 1) {
9696
throw new MissingPropertyException(implode("\r\n", $errorMessages));
9797
}
9898
}

0 commit comments

Comments
 (0)