Skip to content

Commit c14e6da

Browse files
committed
Add more details to comment
Signed-off-by: twobiers <[email protected]>
1 parent a5c0e9e commit c14e6da

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

pkg/reconciler/managed/reconciler.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1410,8 +1410,12 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (resu
14101410

14111411
if observation.ResourceExists {
14121412
// When a resource exists or is just created, it might have received
1413-
// a non-deterministic external name, which we need to persist.
1413+
// a non-deterministic external name after its creation, which we need to persist.
14141414
// We do this by updating the critical annotations.
1415+
// This is needed because some resources might not receive an external-name directly
1416+
// after the creation, but later as part of an asynchronous process.
1417+
// When Crossplane supports asynchronous creation of resources natively, this logic
1418+
// might not be needed anymore and can be revisited.
14151419
if err := r.managed.UpdateCriticalAnnotations(ctx, managed); err != nil {
14161420
log.Debug(errUpdateManagedAnnotations, "error", err)
14171421
record.Event(managed, event.Warning(reasonCannotUpdateManaged, errors.Wrap(err, errUpdateManagedAnnotations)))

0 commit comments

Comments
 (0)