Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec not passed on long integer #21

Closed
andraantariksa opened this issue Nov 16, 2019 · 1 comment
Closed

Spec not passed on long integer #21

andraantariksa opened this issue Nov 16, 2019 · 1 comment

Comments

@andraantariksa
Copy link
Contributor

andraantariksa commented Nov 16, 2019 •
edited
Loading

When I run crystal spec, it will give me a 2 test error, which caused by StackOverFlow. Actually, the JSON implementation also have a StackOverFlow when it try to parse -9223372036854775808. So, I think the test it's pretty trivial and I change it into -9223372036854775807 which works fine

require "json"

puts Int64.from_json("-9223372036854775808")

https://play.crystal-lang.org/#/r/80z2

Can I make a pull request to change the test?
@veelenga
Copy link
Member

Thanks. Could you please do that as a part of #22 ?

veelenga pushed a commit that referenced this issue Nov 18, 2019
@andraantariksa @veelenga
Updated to Crystal 0.28.0 (#22)
d02de85 
* Updated to Crystal 0.28.0

* Removing trivial i64 minimum value test #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@veelenga @andraantariksa