chore: add ESLint setup

- Add .eslintrc.json with comprehensive rules
- Update package.json with ESLint dependencies
- Improve lint scripts to cover more files
- Add check script to run format, lint, and tests

Author: Ali-Sdg90

.eslintrc.json

@@ -0,0 +1,139 @@
+{
+    "root": true,
+    "ignorePatterns": [
+        "node_modules/",
+        "coverage/",
+        "dist/",
+        "build/",
+        "scripts/**",
+        ".*/**/*.js.snap"
+    ],
+    "env": {
+        "node": true,
+        "es2021": true,
+        "jest": true
+    },
+    "parserOptions": {
+        "ecmaVersion": "latest",
+        "sourceType": "commonjs",
+        "ecmaFeatures": {
+            "globalReturn": false
+        }
+    },
+    "plugins": ["prettier", "jest", "import", "node"],
+    "extends": [
+        "eslint:recommended",
+        "plugin:node/recommended",
+        "plugin:jest/recommended",
+        "plugin:import/recommended",
+        "plugin:prettier/recommended"
+    ],
+    "settings": {
+        "import/ignore": ["node_modules", "\\.json$"],
+        "node": {
+            "tryExtensions": [".js", ".json", ".node"]
+        }
+    },
+    "rules": {
+        "prettier/prettier": [
+            "error",
+            {
+                "endOfLine": "auto"
+            }
+        ],
+
+        /* Preferred style */
+        "quotes": [
+            "error",
+            "double",
+            { "avoidEscape": true, "allowTemplateLiterals": true }
+        ],
+        "semi": ["error", "always"],
+        "indent": [
+            "error",
+            4,
+            { "SwitchCase": 1, "ignoredNodes": ["TemplateLiteral"] }
+        ],
+        "comma-dangle": ["error", "only-multiline"],
+
+        /* Best practices */
+        "eqeqeq": ["error", "always"],
+        "no-var": "error",
+        "prefer-const": ["error", { "destructuring": "all" }],
+        "curly": ["error", "multi-line"],
+        "no-implicit-coercion": "error",
+        "no-unsafe-optional-chaining": "error",
+        "consistent-return": "off",
+
+        /* Practical runtime safety (nice for bots) */
+        "no-console": ["warn", { "allow": ["warn", "error", "info"] }],
+        "no-constant-condition": ["error", { "checkLoops": false }],
+        "no-useless-return": "warn",
+        "no-unreachable-loop": "error",
+
+        /* Node-specific */
+        "node/no-unsupported-features/es-syntax": "off",
+        "node/no-unpublished-require": "off",
+        "node/no-missing-require": "off",
+
+        /* Import plugin */
+        "import/no-unresolved": "off",
+        "import/no-extraneous-dependencies": "off",
+        "node/no-extraneous-require": "off",
+        "no-redeclare": "off",
+        "import/order": [
+            "error",
+            {
+                "groups": [
+                    "builtin",
+                    "external",
+                    "internal",
+                    "parent",
+                    "sibling",
+                    "index"
+                ],
+                "newlines-between": "always",
+                "alphabetize": { "order": "asc", "caseInsensitive": true }
+            }
+        ],
+
+        /* Common relaxations for this project */
+        "no-unused-vars": [
+            "warn",
+            { "argsIgnorePattern": "^_", "varsIgnorePattern": "^_" }
+        ],
+
+        /* Jest */
+        "jest/no-disabled-tests": "warn",
+        "jest/no-focused-tests": "error",
+        "jest/no-identical-title": "error",
+
+        /* Code clarity */
+        "max-len": [
+            "warn",
+            {
+                "code": 120,
+                "ignoreUrls": true,
+                "ignoreStrings": true,
+                "ignoreTemplateLiterals": true
+            }
+        ]
+    },
+
+    "overrides": [
+        {
+            "files": ["**/__tests__/**", "**/*.test.js", "**/*.spec.js"],
+            "env": { "jest": true },
+            "rules": {
+                "no-unused-expressions": "off",
+                "no-console": "off"
+            }
+        },
+        {
+            "files": ["scripts/**", "*.config.js", "**/bin/**"],
+            "rules": {
+                "no-console": "off"
+            }
+        }
+    ]
+}

.husky/pre-commit

@@ -1 +1,3 @@
+npm run format:check
+npm run lint
 npm test

__tests__/commands/ban.test.js

@@ -21,6 +21,9 @@ describe("banCommand (isolated)", () => {
                 telegram: { sendMessage: jest.fn() },
             };
             await banCommand(ctx);
+
+            expect(ctx.reply).not.toHaveBeenCalled();
+            expect(ctx.telegram.sendMessage).not.toHaveBeenCalled();
         });
     });
 
@@ -197,6 +200,9 @@ describe("banCommand (isolated)", () => {
                 telegram: { sendMessage: jest.fn() },
             };
             await banCommand(ctx);
+
+            expect(ctx.reply).not.toHaveBeenCalled();
+            expect(ctx.telegram.sendMessage).not.toHaveBeenCalled();
         });
     });
 
@@ -325,9 +331,3 @@ describe("banCommand (isolated)", () => {
         });
     });
 });
-const ctx = {
-    message: { chat: { id: 12345 }, reply_to_message: { text: "🆔 777" } },
-    from: { username: "adminUser" },
-    reply: jest.fn(),
-    telegram: { sendMessage: jest.fn().mockResolvedValue(true) },
-};

__tests__/commands/registerCommands.test.js

@@ -4,8 +4,6 @@ describe("registerCommands", () => {
     beforeEach(() => {
         jest.resetModules();
         jest.clearAllMocks();
-
-        mockErrorReply = jest.fn();
     });
 
     test("registers expected commands on the bot", () => {

__tests__/handlers/messages.test.js

@@ -14,6 +14,8 @@ describe("messages handler", () => {
         const handler = bot.on.mock.calls[0][1];
         const ctx = { message: { pinned_message: {} } };
         await handler(ctx, jest.fn());
+
+        expect(handler).toBeDefined();
     });
 
     test("messages handler handles missing username in private message and includes placeholder", async () => {
@@ -204,6 +206,8 @@ describe("messages handler", () => {
             message: {},
         };
         await handler(ctx, jest.fn());
+
+        expect(cfg.blockedUsers.has(999)).toBe(true);
     });
 
     test("detects and registers valid username during allowed time", async () => {
@@ -251,6 +255,10 @@ describe("messages handler", () => {
 
         // Restore original Date
         global.Date = realDate;
+
+        expect(ctx.reply).toHaveBeenCalledWith(
+            "✅ یوزرنیم شما با موفقیت ثبت شد."
+        );
     });
 
     test("messages handler returns early on pinned_message present", async () => {
@@ -271,33 +279,17 @@ describe("messages handler", () => {
             from: { id: 1 },
         };
         await bot._handler(ctx, jest.fn());
-        // if no exception thrown, test passes
-    });
-
-    test("startMessage handles error when pinChatMessage fails", async () => {
-        const bot = { start: (fn) => (bot._handler = fn) };
-        const register = require("../../bot/handlers/startMessage");
-        register(bot);
-
-        const ctx = {
-            chat: { type: "private", id: 10 },
-            from: { first_name: "F", last_name: "L" },
-            reply: jest.fn().mockResolvedValue({ message_id: 55 }),
-            pinChatMessage: jest.fn().mockRejectedValue(new Error("pin fail")),
-            telegram: { sendMessage: jest.fn() },
-        };
 
-        await bot._handler(ctx);
-        // no throw equals pass
+        expect(bot.on).toHaveBeenCalledWith("message", expect.any(Function));
     });
 
-    test("returns early for pinned_message", () => {
+    test("returns early for pinned_message", async () => {
         const bot = { on: jest.fn() };
         require("../../bot/handlers/messages")(bot);
         const handler = bot.on.mock.calls[0][1];
 
         const ctx = { message: { pinned_message: {} } };
-        expect(handler(ctx)).resolves.toBeUndefined();
+        await expect(handler(ctx)).resolves.toBeUndefined();
     });
 
     test("private valid username registers and sends admin message during allowed time", async () => {

__tests__/handlers/newMembers.test.js

@@ -16,6 +16,11 @@ describe("newMembers handler (isolated)", () => {
             register(bot);
             const handler = bot.on.mock.calls[0][1];
             await handler({ message: {} });
+
+            expect(bot.on).toHaveBeenCalledWith(
+                "new_chat_members",
+                expect.any(Function)
+            );
         });
     });
 
@@ -29,6 +34,11 @@ describe("newMembers handler (isolated)", () => {
             register(bot);
             const handler = bot.on.mock.calls[0][1];
             await handler({ message: { new_chat_participant: null } });
+
+            expect(console.error).toHaveBeenCalledWith(
+                "Invalid member object:",
+                null
+            );
         });
     });
 
@@ -385,6 +395,8 @@ describe("newMembers handler (isolated)", () => {
 
         const ctx = { message: { new_chat_participant: null } };
         await bot._handler(ctx);
+
+        expect(ctx.replyWithHTML).toBeUndefined();
     });
 
     test("newMembers handler removes bot and kicks member", async () => {

__tests__/handlers/startMessage.test.js

@@ -169,9 +169,6 @@ describe("startMessage handler", () => {
             "@yourusername"
         );
     });
-});
-describe("startMessage handler", () => {
-    beforeEach(() => jest.resetModules());
 
     test("for non-private chat calls sendReaction and does not reply", () => {
         const mockSendReaction = jest.fn();

__tests__/middlewares/errorHandler.test.js

@@ -72,6 +72,8 @@ describe("errorHandler middleware", () => {
 
         await handler(err, ctx);
 
+        expect(ctx.telegram.sendMessage).not.toHaveBeenCalled();
+
         // Fast-forward timers to run scheduled sendErrorToAdmin
         jest.advanceTimersByTime(7000);
 
@@ -85,6 +87,8 @@ describe("errorHandler middleware", () => {
         const ctx = {}; // no telegram
 
         await handler(err, ctx);
+
+        expect(ctx.telegram).toBeUndefined();
     });
 
     test("schedules send when 429 rate limit is present", async () => {

__tests__/services/azure.test.js

@@ -90,7 +90,6 @@ describe("createWorkItem service", () => {
 
     test("createWorkItem replies when isNewID true after POST", async () => {
         await jest.isolateModulesAsync(async () => {
-            const axios = require("axios");
             jest.doMock("axios", () => ({
                 get: jest.fn().mockResolvedValue({
                     data: {

bot/commands/ban.js

@@ -13,7 +13,7 @@ const banCommand = async (ctx) => {
         return;
     }
 
-    if (ctx.message.chat.id != ADMIN_GROUP_ID) {
+    if (String(ctx.message.chat.id) !== String(ADMIN_GROUP_ID)) {
         return;
     }