upgrade to laravel 12.x (#58)

Author: rumansaleem

app/Exceptions/QuizVerificationException.php

@@ -12,7 +12,7 @@ public function render($request)
             return response()->json([
                 'status' => 'error',
                 'message' => $this->getMessage()
-            ], 401);
+            ], 403);
         }
 
         flash($this->getMessage())->warning();

app/Http/Controllers/PagesController.php

@@ -2,14 +2,14 @@
 
 namespace App\Http\Controllers;
 
-use Carbon\Carbon;
+use Illuminate\Support\Facades\Date;
 
 class PagesController extends Controller
 {
     public function index()
     {
         return view('welcome', [
-            'timeLeft' => max(0, Carbon::now()->diffInSeconds(Carbon::parse(env('SANKALAN_START_TIME')), false)),
+            'timeLeft' => max(0, Date::now()->diffInSeconds(Date::parse(env('SANKALAN_START_TIME')), false)),
         ]);
     }
 

app/Http/Controllers/QuestionResponseController.php

@@ -4,9 +4,8 @@
 
 use App\Models\QuestionResponse;
 use App\Models\Quiz;
-use Auth;
+use Illuminate\Support\Facades\Auth;
 use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Session;
 use Symfony\Component\HttpFoundation\Response;
 
 class QuestionResponseController extends Controller
@@ -20,30 +19,46 @@ public function store(Request $request, Quiz $quiz)
         if ($quiz->isTimeLimitExceeded($team)) {
             flash('Your time limit exceeded!')->error();
 
-            return $this->getJsonOrRedirect(Response::HTTP_UNAUTHORIZED);
+            if ($request->expectsJson()) {
+                return response()->json([
+                    'status' => 'error',
+                    'message' => 'Your time limit exceeded!'
+                ], Response::HTTP_FORBIDDEN);
+            }
+
+            return redirect()->back();
         }
 
         flash('Your response has been recorded! All The Best!')->success();
 
-        return $this->getJsonOrRedirect(Response::HTTP_ACCEPTED);
-    }
-
-    private function getJsonOrRedirect($status = 202)
-    {
-        if (! request()->expectsJson()) {
-            return redirect()->back();
+        if ($request->expectsJson()) {
+            return response()->json([
+                'status' => 'success',
+                'message' => 'Your response has been recorded! All The Best!'
+            ], Response::HTTP_OK);
         }
 
-        return response()->json([
-            'message' => Session::pull('flash_notification')->toArray()[0],
-        ], $status);
+        return redirect()->back();
     }
 
     public function saveQuestionResponse(Request $request, Quiz $quiz)
     {
         $team = $quiz->event->participatingTeamByUser(Auth::user());
-        $quizResponseId = $quiz->participationByTeam($team)->id;
 
+        if (!$quiz->isVerified()) {
+
+            if ($request->expectsJson()) {
+                return response()->json([
+                    'status' => 'error',
+                    'message' => 'Quiz must be verified before submitting responses.'
+                ], Response::HTTP_FORBIDDEN);
+            }
+
+            flash('Quiz must be verified before submitting responses.')->error();
+            return redirect()->back();
+        }
+
+        $quizResponseId = $quiz->participationByTeam($team)->id;
         $questionId = $request->question_id;
         $responseKey = $request->response_key;
 
@@ -52,13 +67,19 @@ public function saveQuestionResponse(Request $request, Quiz $quiz)
             ['response_keys' => $responseKey]
         );
 
-        return response()->json([
-            'message' => 'Your response has been saved!',
-            'question_response' => [
-                'question_id' => $questionId,
-                'question_response_id' => $questionResponse->id,
-                'response_key' => $responseKey,
-            ],
-        ]);
+
+        if ($request->expectsJson()) {
+            return response()->json([
+                'message' => 'Your response has been saved!',
+                'question_response' => [
+                    'question_id' => $questionId,
+                    'question_response_id' => $questionResponse->id,
+                    'response_key' => $responseKey,
+                ]
+            ]);
+        }
+
+        flash('Your response has been saved!')->success();
+        return redirect()->back();
     }
 }

app/Http/Kernel.php

@@ -14,11 +14,11 @@ class Kernel extends HttpKernel
      * @var array
      */
     protected $middleware = [
-        \App\Http\Middleware\CheckForMaintenanceMode::class,
+        \App\Http\Middleware\TrustProxies::class,
         \Illuminate\Foundation\Http\Middleware\ValidatePostSize::class,
+        \Illuminate\Foundation\Http\Middleware\PreventRequestsDuringMaintenance::class,
         \App\Http\Middleware\TrimStrings::class,
         \Illuminate\Foundation\Http\Middleware\ConvertEmptyStringsToNull::class,
-        \App\Http\Middleware\TrustProxies::class,
     ];
 
     /**
@@ -31,15 +31,14 @@ class Kernel extends HttpKernel
             \App\Http\Middleware\EncryptCookies::class,
             \Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse::class,
             \Illuminate\Session\Middleware\StartSession::class,
-            // \Illuminate\Session\Middleware\AuthenticateSession::class,
             \Illuminate\View\Middleware\ShareErrorsFromSession::class,
             \App\Http\Middleware\VerifyCsrfToken::class,
             \Illuminate\Routing\Middleware\SubstituteBindings::class,
         ],
 
         'api' => [
-            'throttle:60,1',
-            'bindings',
+            \Illuminate\Routing\Middleware\ThrottleRequests::class . ':api',
+            \Illuminate\Routing\Middleware\SubstituteBindings::class,
         ],
     ];
 
@@ -53,10 +52,11 @@ class Kernel extends HttpKernel
     protected $routeMiddleware = [
         'auth' => \App\Http\Middleware\Authenticate::class,
         'auth.basic' => \Illuminate\Auth\Middleware\AuthenticateWithBasicAuth::class,
-        'bindings' => \Illuminate\Routing\Middleware\SubstituteBindings::class,
         'cache.headers' => \Illuminate\Http\Middleware\SetCacheHeaders::class,
         'can' => \Illuminate\Auth\Middleware\Authorize::class,
         'guest' => \App\Http\Middleware\RedirectIfAuthenticated::class,
+        'password.confirm' => \Illuminate\Auth\Middleware\RequirePassword::class,
+        'precognitive' => \Illuminate\Foundation\Http\Middleware\HandlePrecognitiveRequests::class,
         'signed' => \Illuminate\Routing\Middleware\ValidateSignature::class,
         'throttle' => \Illuminate\Routing\Middleware\ThrottleRequests::class,
         'verified' => \Illuminate\Auth\Middleware\EnsureEmailIsVerified::class,

app/Http/Middleware/TrustProxies.php

@@ -2,15 +2,15 @@
 
 namespace App\Http\Middleware;
 
-use Fideloper\Proxy\TrustProxies as Middleware;
+use Illuminate\Http\Middleware\TrustProxies as Middleware;
 use Illuminate\Http\Request;
 
 class TrustProxies extends Middleware
 {
     /**
      * The trusted proxies for this application.
      *
-     * @var array
+     * @var array|string|null
      */
     protected $proxies;
 
@@ -19,5 +19,13 @@ class TrustProxies extends Middleware
      *
      * @var int
      */
-    protected $headers = Request::HEADER_X_FORWARDED_ALL;
+    protected $headers = [
+        Request::HEADER_FORWARDED,
+        Request::HEADER_X_FORWARDED_FOR,
+        Request::HEADER_X_FORWARDED_HOST,
+        Request::HEADER_X_FORWARDED_PORT,
+        Request::HEADER_X_FORWARDED_PROTO,
+        Request::HEADER_X_FORWARDED_PREFIX,
+        Request::HEADER_X_FORWARDED_AWS_ELB,
+    ];
 }

app/Models/Event.php

@@ -5,6 +5,7 @@
 use Illuminate\Database\Eloquent\Collection;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
+use Illuminate\Support\Facades\Date;
 
 class Event extends Model
 {
@@ -13,21 +14,24 @@ class Event extends Model
     /**
      * The attributes that are NOT mass assignable.
      *
-     * @var array
+     * @var array<string>
      */
     protected $guarded = [];
 
     /**
-     * The attributes that are of DateTime type, mutated to instance of Carbon.
+     * The attributes that should be cast.
      *
-     * @var array
+     * @var array<string, string>
      */
-    protected $dates = ['started_at', 'ended_at'];
+    protected $casts = [
+        'started_at' => 'datetime',
+        'ended_at' => 'datetime',
+    ];
 
     /**
      * The attributes that are appended for array.
      *
-     * @var array
+     * @var array<string>
      */
     protected $appends = ['isLive', 'hasEnded'];
 
@@ -99,51 +103,41 @@ public function setLive()
             return true;
         }
 
-        return $this->update(['started_at' => now()]);
+        return $this->update([
+            'started_at' => Date::now(),
+        ]);
     }
 
     /**
-     * End this event (When the event gets over).
-     *
-     * @return bool
-     */
-    public function end()
-    {
-        if ($this->isLive) {
-            return $this->update(['ended_at' => now()]);
-        }
-
-        return false;
-    }
-
-    /**
-     * Accessor to access isLive attribute.
+     * Get is live attribute.
      *
      * @return bool
      */
     public function getIsLiveAttribute()
     {
-        return $this->hasStarted && !$this->hasEnded;
+        return !is_null($this->started_at) && is_null($this->ended_at);
     }
 
     /**
-     * Has the event started?
+     * Get has ended attribute.
      *
      * @return bool
      */
-    public function getHasStartedAttribute()
+    public function getHasEndedAttribute()
     {
-        return (bool) $this->started_at;
+        return !is_null($this->ended_at);
     }
 
     /**
-     * Has the event ended?
+     * End an event.
      *
      * @return bool
      */
-    public function getHasEndedAttribute()
+    public function end()
     {
-        return (bool) $this->ended_at;
+        return $this->update([
+            'ended_at' => Date::now(),
+        ]);
     }
 
     /**