Skip to content

Commit 6484fff

Browse files
QuadAcesStuart Cutbushderekxu04
authored
Cw2-18 Improve Semantic HTML (#7)
* changed the h1 tags * changed image alt tags * changed tailwind * CW2-3 Add events section (#4) * added events template * removed section * modified events to coordinate with navbar on click --------- Co-authored-by: Stuart Cutbush <[email protected]> Co-authored-by: Derek Xu <[email protected]> * changes to make linter approve * formatted code? --------- Co-authored-by: Stuart Cutbush <[email protected]> Co-authored-by: Derek Xu <[email protected]>
1 parent b236314 commit 6484fff

File tree

4 files changed

+31
-12
lines changed

4 files changed

+31
-12
lines changed

components/About/index.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const About = () => {
55
<section className="py-8 xl:px-24 sm:px-10 px-5" id="about">
66
<div className="text-center my-10">
77
<p className="text-[#3977F8] font-game text-xl">01</p>
8-
<h1 className="font-bold text-6xl">ABOUT</h1>
8+
<h2 className="font-bold text-6xl">ABOUT</h2>
99
</div>
1010
<div className="flex justify-center items-center">
1111
<div className="lg:grid grid-cols-6 flex-1 max-w-[90rem]">
@@ -14,7 +14,7 @@ const About = () => {
1414
<div className="flex items-center justify-center">
1515
<Image src="/assets/csesoc_icon.svg" alt="CSESoc Icon" width={150} height={150} />
1616
</div>
17-
<h1 className="mt-10 text-3xl font-extrabold">CSESoc</h1>
17+
<h2 className="mt-10 text-3xl font-extrabold">CSESoc</h2>
1818
<p className="text-[#727B8C] font-medium">unsw-computer-science-soc</p>
1919
<button className="bg-[#444F6F] w-full my-5 py-2 rounded">Follow</button>
2020
<p>
@@ -40,7 +40,7 @@ const About = () => {
4040
</div>
4141
{/* RIGHT SIDE */}
4242
<div className="col-span-4 lg:mt-0 mt-10">
43-
<div className="rounded border border-[#595F6D] p-5 2xl:h-80 xl:h-64 lg:h-48 sm:h-36 h-32 h-full">
43+
<div className="rounded border border-[#595F6D] p-5 2xl:h-80 xl:h-64 lg:h-48 sm:h-36 h-full">
4444
<p className="text-xs">
4545
csesoc/README<span className="text-[#7A8192]">.md</span>
4646
</p>

components/Footer.tsx

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1+
import Image from 'next/image';
12
import Link from 'next/link';
23

34
const Footer = () => {
45
return (
56
<section>
67
<div className="sm:flex justify-between">
78
<div className="flex items-center">
8-
<img src="assets/csesoc_logo_white.svg" alt="CSESoc Logo" />
9+
<Image src="assets/csesoc_logo_white.svg" alt="CSESoc Logo" />
910
<Link href="/flag/ollie_is_hiding.png" target="_blank" className="sm:hidden block">
10-
<img
11+
<Image
1112
src="/flag/ollie_is_hiding.png"
1213
alt="Ollie"
1314
draggable="false"
@@ -16,7 +17,7 @@ const Footer = () => {
1617
className="ml-10"
1718
/>
1819
</Link>
19-
<img
20+
<Image
2021
src="/flag/ollie_is_hiding.png"
2122
alt="Ollie"
2223
draggable="false"
@@ -30,7 +31,7 @@ const Footer = () => {
3031
<p>© 2021 — CSESoc UNSW</p>
3132
</div>
3233
</div>
33-
<img
34+
<Image
3435
src="assets/sponsors_backdrop.svg"
3536
alt="Sponsors backdrop"
3637
className="absolute bottom-0 left-0 w-screen -z-10"

components/Landing/index.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const Landing = () => {
1313
<div>
1414
<div className="font-semibold">
1515
<p>{'<h1>'}</p>
16-
<h1 className="font-black 2xl:text-8xl lg:text-6xl text-4xl">Hello World!</h1>
16+
<h2 className="font-black 2xl:text-8xl lg:text-6xl text-4xl">Hello World!</h2>
1717
<p>{'</h1>'}</p>
1818
</div>
1919
<div className="font-semibold mt-10">

components/ResourcesAndContacts/index.tsx

+22-4
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const ResourcesAndContacts = () => {
1515

1616
<div className="text-center my-10">
1717
<p className="text-[#3977F8] font-game text-xl">03</p>
18-
<h1 className="font-bold text-6xl">RESOURCES & CONTACTS</h1>
18+
<h2 className="font-bold text-6xl">RESOURCES & CONTACTS</h2>
1919
</div>
2020

2121
<div className="py-8 bg-no-repeat bg-center">
@@ -122,23 +122,41 @@ const ResourcesAndContacts = () => {
122122
<div className="md:mt-10 mt-5">
123123
<div className="grid grid-cols-3 1 gap-x-9 gap-y-5 mb-10">
124124
<a href="https://bit.ly/CSESocDiscord" target="_blank" className={socialsBoxStyling}>
125-
<Image src="assets/discord_logo.svg" alt="" width={25} height={25} className="mr-1" />
125+
<Image
126+
src="assets/discord_logo.svg"
127+
alt="discord logo"
128+
width={25}
129+
height={25}
130+
className="mr-1"
131+
/>
126132
<p className="text-xl font-bold m-2">DISCORD</p>
127133
</a>
128134
<a
129135
href="https://www.facebook.com/csesoc/"
130136
target="_blank"
131137
className={socialsBoxStyling}
132138
>
133-
<Image src="assets/fb_logo.svg" alt="" width={25} height={25} className="mr-1" />
139+
<Image
140+
src="assets/fb_logo.svg"
141+
alt="facebook logo"
142+
width={25}
143+
height={25}
144+
className="mr-1"
145+
/>
134146
<p className="text-xl font-bold m-2">FACEBOOK</p>
135147
</a>
136148
<a
137149
href="https://www.facebook.com/groups/csesoc"
138150
target="_blank"
139151
className={socialsBoxStyling}
140152
>
141-
<Image src="assets/group_icon.svg" alt="" width={25} height={25} className="mr-1" />
153+
<Image
154+
src="assets/group_icon.svg"
155+
alt="facebook group"
156+
width={25}
157+
height={25}
158+
className="mr-1"
159+
/>
142160
<p className="text-xl font-bold m-2">FACEBOOK GROUP</p>
143161
</a>
144162
</div>

0 commit comments

Comments
 (0)