Merged
Conversation
…exactly the same component at ./resources
derekxu04
suggested changes
Jun 27, 2024
Contributor
derekxu04
left a comment
There was a problem hiding this comment.
Ok nice work.
Ok a few things
- I think the numbers for each section on the landing page, but not so much the navbar / each of the pages. So: remove the numbers from the navbar + the pages associated with them, probably make the text bigger and closer together
- I think the About section is too much text, I am not too sure what I want to put instead, can start by putting maybe just a few sentences next to the logo idk (this component will be moved to the
/aboutpage) - I think buttons linking to the relevant pages would be good (e.g. "Learn more" after the about part, "See all events" for the events page)
derekxu04
suggested changes
Jun 29, 2024
Contributor
derekxu04
left a comment
There was a problem hiding this comment.
- Haven't deleted the numbers for resources and contact us.
- For the about section on the landing page, I think using the entire component is too much. I think get rid of the pinned section (but don't change the original component since we need it for the about section), instead of writing out the full content, have text in the README like "Learn more" or something that directs to /about. In line with this, can get rid of some of the stuff on the left to make it even
- "See all events" button should not stretch over that much
Contributor
|
I think we should still change up the about section for the landing page, maybe remove the entire README concept, but I'm happy to merge this now and then assign a new ticket for the about section |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the changes are required?
To clean up the landing page
Changes
Screenshots
Comments