Merged
Conversation
chlowoee
changed the title
derekxu04
approved these changes
Jul 12, 2024
Contributor
derekxu04
left a comment
derekxu04
left a comment
There was a problem hiding this comment.
Nice work on your first ticket, looks really good!
Some nitpicks, otherwise happy to merge
| 'border border-[#595F6D] rounded-lg hover:border-[#788093] hover:bg-[#070034] hover:bg-opacity-75 transition-all duration-300'; | ||
| const socialsBoxStyling = | ||
| 'xl:col-span-1 col-span-3 flex justify-center pt-2 pb-2 border border-[#595F6D] hover:border-[#788093] rounded-lg hover:bg-[#070034] hover:bg-opacity-75 transition-all duration-300'; | ||
| // const socialsBoxStyling = |
| 'xl:col-span-1 col-span-3 flex justify-center pt-2 pb-2 border border-[#595F6D] hover:border-[#788093] rounded-lg hover:bg-[#070034] hover:bg-opacity-75 transition-all duration-300'; | ||
| // const socialsBoxStyling = | ||
| // 'xl:col-span-1 col-span-3 flex justify-center pt-2 pb-2 border border-[#595F6D] hover:border-[#788093] rounded-lg hover:bg-[#070034] hover:bg-opacity-75 transition-all duration-300'; | ||
| const logostyle = |
Contributor
There was a problem hiding this comment.
nit: this is only used once I think, you can probably just get rid of the variable and use it inline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the changes are required?
To show which resources are made by DevSoc
Changes
Made by CSESocandMade by DevSoc(has hover animation and directs to DevSoc's website) above each society's resource cards.Screenshots
Before
After
Comments