Add test for r2 score in cross_val_score. Pull request/2e09aad8. #40
Open
kavir1698 wants to merge 2 commits into
Open
Add test for r2 score in cross_val_score. Pull request/2e09aad8. #40kavir1698 wants to merge 2 commits into
kavir1698 wants to merge 2 commits into
Conversation
Owner
|
Thank you. Sorry that I haven't had the time to look at this in detail, but will do when I can. It's a bummer that Travis is not working with ScikitLearn.jl at the moment. |
Author
|
No rush, thank you for the good work. |
Owner
|
Sorry for the delay. Travis is not working for this package right now, so I had to test this PR locally. To complicate matters further, you need the latest version of some packages (use When I test your pull request, I get this error: ERROR: LoadError: MethodError: no method matching mean(::Array{Union{Float64, Missings.Missing},1}, ::StatsBase.Weights{Float64,Float64,Array{Float64,1}}, ::Int64)
Closest candidates are:
mean(::AbstractArray{T<:Number,N} where N, ::StatsBase.AbstractWeights{W<:Real,T,V} where V<:AbstractArray{T,1} where T<:Real, ::Int64) where {T<:Number, W<:Real} at /Users/cedric/.julia/v0.6/StatsBase/src/weights.jl:467
mean(::AbstractArray, ::StatsBase.AbstractWeights) at /Users/cedric/.julia/v0.6/StatsBase/src/weights.jl:453
mean(::AbstractArray{T,N} where N, ::Any) where T at statistics.jl:57
...
Stacktrace:
[1] #r2_score#58(::Void, ::String, ::Function, ::Array{Union{Float64, Missings.Missing},1}, ::Array{Float64,1}) at /Users/cedric/.julia/v0.6/ScikitLearn/src/scorer.jl:91
[2] r2_score(::Array{Union{Float64, Missings.Missing},1}, ::Array{Float64,1}) at /Users/cedric/.julia/v0.6/ScikitLearn/src/scorer.jl:79
[3] #call#67(::Void, ::ScikitLearn.Skcore.PredictScorer, ::PyCall.PyObject, ::Array{Union{Float64, Missings.Missing},2}, ::Array{Union{Float64, Missings.Missing},1}) at /Users/cedric/.julia/v0.6/ScikitLearn/src/scorer.jl:166
[4] _score(::PyCall.PyObject, ::Array{Union{Float64, Missings.Missing},2}, ::Array{Union{Float64, Missings.Missing},1}, ::ScikitLearn.Skcore.PredictScorer) at /Users/cedric/.julia/v0.6/ScikitLearn/src/cross_validation.jl:651
[5] #_fit_and_score#105(::Bool, ::Bool, ::String, ::Function, ::PyCall.PyObject, ::Array{Union{Float64, Missings.Missing},2}, ::Array{Union{Float64, Missings.Missing},1}, ::ScikitLearn.Skcore.PredictScorer, ::Array{Int64,1}, ::Array{Int64,1}, ::Int64, ::Void, ::Void) at /Users/cedric/.julia/v0.6/ScikitLearn/src/cross_validation.jl:574
[6] (::ScikitLearn.Skcore.##93#94{Int64,Void,PyCall.PyObject,Array{Union{Float64, Missings.Missing},2},Array{Union{Float64, Missings.Missing},1}})(::Tuple{Array{Int64,1},Array{Int64,1}}) at ./<missing>:0
[7] copy!(::Array{Float64,1}, ::Base.Generator{Array{Tuple{Array{Int64,1},Array{Int64,1}},1},ScikitLearn.Skcore.##93#94{Int64,Void,PyCall.PyObject,Array{Union{Float64, Missings.Missing},2},Array{Union{Float64, Missings.Missing},1}}}) at ./abstractarray.jl:572
[8] _collect(::Type{Float64}, ::Base.Generator{Array{Tuple{Array{Int64,1},Array{Int64,1}},1},ScikitLearn.Skcore.##93#94{Int64,Void,PyCall.PyObject,Array{Union{Float64, Missings.Missing},2},Array{Union{Float64, Missings.Missing},1}}}, ::Base.HasShape) at ./array.jl:363
[9] #cross_val_score#92(::String, ::Int64, ::Int64, ::Int64, ::Void, ::Function, ::PyCall.PyObject, ::Array{Union{Float64, Missings.Missing},2}, ::Array{Union{Float64, Missings.Missing},1}) at /Users/cedric/.julia/v0.6/ScikitLearn/src/cross_validation.jl:279
[10] (::ScikitLearn.Skcore.#kw##cross_val_score)(::Array{Any,1}, ::ScikitLearn.Skcore.#cross_val_score, ::PyCall.PyObject, ::Array{Union{Float64, Missings.Missing},2}, ::Array{Union{Float64, Missings.Missing},1}) at ./<missing>:0
[11] test_corss_val_r2_score() at /Users/cedric/.julia/v0.6/ScikitLearn/test/test_crossvalidation.jl:234
[12] all_test_crossvalidation() at /Users/cedric/.julia/v0.6/ScikitLearn/test/test_crossvalidation.jl:243
[13] include_from_node1(::String) at ./loading.jl:569
[14] include(::String) at ./sysimg.jl:14
[15] process_options(::Base.JLOptions) at ./client.jl:305
[16] _start() at ./client.jl:371
while loading /Users/cedric/.julia/v0.6/ScikitLearn/test/runtests.jl, in expression starting on line 19Could you please fix it? |
cstjean
requested changes
Apr 28, 2018
cstjean
left a comment
cstjean
left a comment
Owner
There was a problem hiding this comment.
That's a very nice PR, thank you!
| @test length(_score_func_args) == 3 | ||
| end | ||
|
|
||
| function test_corss_val_r2_score() |
There was a problem hiding this comment.
@kavir1698 Be good if you can finish this. Looks like you're almost there.
Owner
|
You may get an obscure error with PyPlot/PyCall. There's no fix for those at the moment. Just ignore it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.