- add desc for page

- check for Route::currentRouteName() internally for navigation
- make params avail to controller through using cache
- make static (closure) routes cacheable through using dummy controller

rdme

Update README.md

Author: ctf0

README.md

@@ -39,6 +39,11 @@ return [
         'a'  => 'is-active',
     ],
 
+    /*
+     * where to search for the template views relative to "resources\views" folder
+     */
+    'templatePath' => 'pages',
+
     /*
      * the path where we will save the route list for multiLocal route resolving
      */
@@ -69,6 +74,19 @@ return [
     });
     ```
 
+### Good Practice
+Ofcourse you are free to code your app the way you want, but just in-case here are the naming convention the package use.
+
+- `title`       > `title_case(some title)`
+- `route_name`  > `str_slug(title)`
+- `action`      > `SomeController\camelCase(title)`
+
+## Notes
+- for the pages with "action" you can get all the page params like **template, title, body, desc, breadCrump** inside your "action@method" by using `extract(cache('the_route_name'));`
+
+<u>**or**</u>
+- if you followed the naming convention above, you can instead use `extract(cache(kebab_case('TheCurrentMethodName')));`
+
 # ToDo
 
 * [ ] CRUD Views for (roles/perms/pages/menus). *any help is appreciated*

src/Controller/DummyController.php

@@ -0,0 +1,21 @@
+<?php
+
+namespace ctf0\SimpleMenu\Controller;
+
+use App\Http\Controllers\Controller;
+use Illuminate\Support\Facades\Route;
+
+class DummyController extends Controller
+{
+    public function handle()
+    {
+        extract(cache(Route::currentRouteName()));
+
+        return view(config('simpleMenu.templatePath').".$template")->with([
+            'title'      => $title,
+            'body'       => $body,
+            'desc'       => $desc,
+            'breadCrump' => $breadCrump,
+        ]);
+    }
+}

src/Models/Page.php

@@ -14,7 +14,7 @@ class Page extends Node
     use HasRoles, HasTranslations;
 
     protected $guarded = ['id'];
-    public $translatable = ['title', 'body', 'prefix', 'url'];
+    public $translatable = ['title', 'body', 'desc', 'prefix', 'url'];
 
     public static function boot()
     {
@@ -32,6 +32,7 @@ public static function boot()
                 });
             }
 
+            Cache::forget($model->route_name);
             File::delete(config('simpleMenu.routeListPath'));
         });
 
@@ -43,6 +44,7 @@ public static function boot()
                 });
             }
 
+            Cache::forget($model->route_name);
             File::delete(config('simpleMenu.routeListPath'));
         });
     }

src/Traits/NavigationTrait.php

@@ -2,6 +2,7 @@
 
 namespace ctf0\SimpleMenu\Traits;
 
+use Illuminate\Support\Facades\Route;
 use Mcamara\LaravelLocalization\Facades\LaravelLocalization;
 
 trait NavigationTrait
@@ -14,8 +15,10 @@ trait NavigationTrait
      *
      * @return [type] [description]
      */
-    public function getUrl($name, $code)
+    public function getUrl($code)
     {
+        $name = Route::currentRouteName();
+
         // routeName is not saved in the db (ex.php artisan make:auth)
         // or only url
         $routesListFile = include $this->listFileDir;

src/Traits/RoutesTrait.php

@@ -3,6 +3,7 @@
 namespace ctf0\SimpleMenu\Traits;
 
 use ctf0\SimpleMenu\Models\Page;
+use Illuminate\Support\Facades\Cache;
 use Illuminate\Support\Facades\File;
 use Illuminate\Support\Facades\Route;
 use Mcamara\LaravelLocalization\Facades\LaravelLocalization;
@@ -19,7 +20,6 @@ public function createRoutes()
     {
         Route::group([
             'prefix'     => LaravelLocalization::setLocale(),
-            'namespace'  => config('simpleMenu.pagesControllerNS'),
             'middleware' => [
                 'web',
                 LocaleSessionRedirect::class,
@@ -62,7 +62,7 @@ protected function pageComp($page)
         // page data
         $title = $page->title;
         $body = $page->body;
-        $desc = $body;
+        $desc = $page->desc;
         $template = $page->template;
         $breadCrump = $page->getAncestors();
 
@@ -95,18 +95,19 @@ protected function routeGen($routeName, $url, $prefix, $action, $roles, $permiss
 
         // dynamic
         if ($action) {
-            Route::get($route, $action)->name($routeName)->middleware([$roles, $permissions]);
+            Cache::forever($routeName, compact('template', 'title', 'body', 'desc', 'breadCrump'));
+
+            Route::get($route)
+            ->uses(config('simpleMenu.pagesControllerNS').'\\'.$action)
+            ->name($routeName)
+            ->middleware([$roles, $permissions]);
         }
         // static
         else {
-            Route::get($route, function () use ($template, $title, $body, $desc, $breadCrump) {
-                return view("pages.{$template}")->with([
-                    'title'      => $title,
-                    'body'       => $body,
-                    'desc'       => $desc,
-                    'breadCrump' => $breadCrump,
-                ]);
-            })
+            Cache::forever($routeName, compact('template', 'title', 'body', 'desc', 'breadCrump'));
+
+            Route::get($route)
+            ->uses('\ctf0\SimpleMenu\Controller\DummyController@handle')
             ->name($routeName)
             ->middleware([$roles, $permissions]);
         }

src/config/simpleMenu.php

@@ -10,6 +10,11 @@
         'a'  => 'is-active',
     ],
 
+    /*
+     * where to search for the template views relative to "resources\views" folder
+     */
+    'templatePath' => 'pages',
+
     /*
      * the path where we will save the route list for multiLocal route resolving
      */

src/database/migrations/2017_02_28_202951_create_pages_table.php

@@ -23,6 +23,7 @@ public function up()
             $table->string('route_name')->nullable();
             $table->json('title');
             $table->json('body')->nullable();
+            $table->json('desc')->nullable();
             $table->json('prefix')->nullable();
             $table->json('url')->nullable();
             $table->timestamps();

src/database/seeds/PagesTableSeeder.php

@@ -11,7 +11,9 @@ class PagesTableSeeder extends Seeder
      */
     public function run()
     {
-        $heros = ['Home', 'Contact Us', 'About'];
+        $faker = Factory::create();
+
+        $heros = ['Home', 'About', 'Contact Us'];
         foreach ($heros as $one) {
             Page::create([
                 'route_name'=> str_slug($one),
@@ -21,14 +23,21 @@ public function run()
                     'en' => $one,
                     'fr' => $one,
                 ],
+                'body' => [
+                    'en' => $faker->text(),
+                    'fr' => $faker->text(),
+                ],
+                'desc' => [
+                    'en' => $faker->text(),
+                    'fr' => $faker->text(),
+                ],
                 'url' => [
                     'en' => str_slug($one),
                     'fr' => str_slug($one),
                 ],
             ]);
         }
 
-        $faker = Factory::create();
         $i = 1;
         while ($i <= 20) {
             $en = $faker->unique()->city;
@@ -45,6 +54,10 @@ public function run()
                     'en' => $faker->text(),
                     'fr' => $faker->text(),
                 ],
+                'desc' => [
+                    'en' => $faker->text(),
+                    'fr' => $faker->text(),
+                ],
                 'prefix' => [
                     'en' => str_slug($faker->unique()->country),
                     'fr' => str_slug($faker->unique()->country),