Kommite märke på koimte sidan för komiteer #179

Alex04412 · 2025-12-05T19:12:49Z

Gör så att komite märken visas upp på deras komite sida på chalmers.it

Copilot

Pull request overview

This pull request adds committee badges (avatars) to committee pages on chalmers.it. The implementation creates a new GroupAvatar component that displays super group avatars using the Gamma API, following the existing pattern for displaying group-related images.

Adds getSuperGroupAvatarURL method to GammaService for fetching super group avatar URLs
Creates new GroupAvatar component to display committee badges with fallback image support
Integrates the component into the group detail page

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
src/services/gammaService.ts	Adds static method to generate super group avatar URLs, following existing URL generation patterns
src/components/GroupAvatar/GroupAvatar.tsx	New component for displaying group avatars with debugging code that should be removed
src/components/GroupAvatar/GroupAvatar.module.scss	Styles for the avatar component including debugging styles that should be removed
src/app/[locale]/(groups)/groups/[id]/page.tsx	Integrates GroupAvatar component into group pages with conditional rendering that needs improvement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-05T19:16:20Z

src/app/[locale]/(groups)/groups/[id]/page.tsx

+      {<GroupAvatar
+        groupAvatarUrl={gammaGroup?.superGroup.id ? GammaService.getSuperGroupAvatarURL(gammaGroup.superGroup.id) : ''}
+        groupName={group.prettyName}
+      />}


The fragment wrapper {...} is unnecessary here. You can directly render the GroupAvatar component without wrapping it in curly braces and a fragment.

Suggested change

{<GroupAvatar

groupAvatarUrl={gammaGroup?.superGroup.id ? GammaService.getSuperGroupAvatarURL(gammaGroup.superGroup.id) : ''}

groupName={group.prettyName}

/>}

<GroupAvatar

groupAvatarUrl={gammaGroup?.superGroup.id ? GammaService.getSuperGroupAvatarURL(gammaGroup.superGroup.id) : ''}

groupName={group.prettyName}

/>

Copilot · 2025-12-05T19:16:21Z

src/app/[locale]/(groups)/groups/[id]/page.tsx

+      {<GroupAvatar
+        groupAvatarUrl={gammaGroup?.superGroup.id ? GammaService.getSuperGroupAvatarURL(gammaGroup.superGroup.id) : ''}
+        groupName={group.prettyName}
+      />}


Passing an empty string as groupAvatarUrl when gammaGroup?.superGroup.id is falsy could cause the FallbackImage component to attempt fetching an invalid URL. Consider conditionally rendering the GroupAvatar component only when a valid superGroup.id exists, similar to how member rendering is handled above (lines 65-84).

Suggested change

{<GroupAvatar

groupAvatarUrl={gammaGroup?.superGroup.id ? GammaService.getSuperGroupAvatarURL(gammaGroup.superGroup.id) : ''}

groupName={group.prettyName}

/>}

{gammaGroup?.superGroup.id && (

<GroupAvatar

groupAvatarUrl={GammaService.getSuperGroupAvatarURL(gammaGroup.superGroup.id)}

groupName={group.prettyName}

/>

)}

Copilot · 2025-12-05T19:16:21Z

src/components/GroupAvatar/GroupAvatar.tsx

+import styles from './GroupAvatar.module.scss';
+
+const GroupAvatar = ({
+  groupAvatarUrl,  


There is trailing whitespace after the comma. Please remove it to maintain code consistency.

Suggested change

groupAvatarUrl,

groupAvatarUrl,

src/components/GroupAvatar/GroupAvatar.tsx

Copilot · 2025-12-05T19:16:22Z

src/components/GroupAvatar/GroupAvatar.module.scss

+.url {
+  margin-top: 0.5rem;
+  font-size: 0.75rem;
+  color: var(--muted-color, #666);
+  word-break: break-all;
+}


These styles are for debugging purposes and should be removed before merging to production.

@copilot open a new pull request to apply changes based on this feedback

GAsplund

Looks good overall, I have one small change request. Check separate comment.

GAsplund · 2025-12-05T19:15:40Z

src/app/[locale]/(groups)/groups/[id]/page.tsx

+      {<GroupAvatar
+        groupAvatarUrl={gammaGroup?.superGroup.id ? GammaService.getSuperGroupAvatarURL(gammaGroup.superGroup.id) : ''}
+        groupName={group.prettyName}
+      />}


Suggested change

{<GroupAvatar

groupAvatarUrl={gammaGroup?.superGroup.id ? GammaService.getSuperGroupAvatarURL(gammaGroup.superGroup.id) : ''}

groupName={group.prettyName}

/>}

<GroupAvatar

groupAvatarUrl={gammaGroup?.superGroup.id ? GammaService.getSuperGroupAvatarURL(gammaGroup.superGroup.id) : ''}

groupName={group.prettyName}

/>

Ehm jag tryckte på commit suggestion och nu runnar inte koden.. ;( vet inte varför

Vad får du för felmeddelande?

Co-authored-by: Goostaf <[email protected]>

Copilot · 2025-12-05T20:04:40Z

@Alex04412 I've opened a new pull request, #181, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <[email protected]>

* Initial plan * Remove debugging URL display and styles from GroupAvatar component Co-authored-by: Alex04412 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Alex04412 <[email protected]>

Alex04412 added 5 commits October 17, 2025 22:57

Added groupavatars

773cba0

Prints

b9b3df7

fix styling for the group avatar

7d95e28

Made a new gammaService that fetches the actual supergroup avatar

57cdad4

Merge branch 'main' into komiteeMarke

09d8da8

Alex04412 requested a review from GAsplund as a code owner December 5, 2025 19:12

Alex04412 requested review from Copilot and removed request for GAsplund December 5, 2025 19:12

Copilot started reviewing on behalf of Alex04412 December 5, 2025 19:13 View session

Copilot AI reviewed Dec 5, 2025

View reviewed changes

GAsplund reviewed Dec 5, 2025

View reviewed changes

Alex04412 and others added 2 commits December 5, 2025 20:19

Update src/app/[locale]/(groups)/groups/[id]/page.tsx

30b8e17

Co-authored-by: Goostaf <[email protected]>

prettier fix

0f7902a

Copilot AI mentioned this pull request Dec 5, 2025

[WIP] Address feedback on committee marker for committee page #181

Merged

3 tasks

Alex04412 and others added 4 commits December 5, 2025 21:04

Update src/components/GroupAvatar/GroupAvatar.tsx

4fb4299

Co-authored-by: Copilot <[email protected]>

Resolved issu where it complained about sending empty string

d891eed

Made it so the groupavatar is to the left of group name

8e85dd4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Kommite märke på koimte sidan för komiteer #179

Kommite märke på koimte sidan för komiteer #179

Uh oh!

Alex04412 commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 5, 2025

Uh oh!

Copilot AI Dec 5, 2025

Uh oh!

Copilot AI Dec 5, 2025

Uh oh!

Uh oh!

Copilot AI Dec 5, 2025

Uh oh!

Alex04412 Dec 5, 2025

Uh oh!

GAsplund left a comment

Uh oh!

GAsplund Dec 5, 2025

Uh oh!

Alex04412 Dec 5, 2025 •

edited

Loading

Uh oh!

GAsplund Dec 5, 2025

Uh oh!

Copilot AI commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kommite märke på koimte sidan för komiteer #179

Are you sure you want to change the base?

Kommite märke på koimte sidan för komiteer #179

Uh oh!

Conversation

Alex04412 commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Alex04412 Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

GAsplund left a comment

Choose a reason for hiding this comment

Uh oh!

GAsplund Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Alex04412 Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GAsplund Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Alex04412 Dec 5, 2025 •

edited

Loading