Merge pull request #1383 from cucumber/enable-jruby-ci-again

Build on JRuby again

Author: vincent-psarga

.circleci/config.yml

@@ -77,6 +77,15 @@ jobs:
       - build
       - test
 
+  build-jruby-9_2:
+    docker:
+      - image: circleci/jruby:9.2.8.0
+
+    working_directory: ~/repo
+    steps:
+      - build
+      - test
+
   build-ruby-latest:
     docker:
       - image: circleci/ruby:latest
@@ -162,6 +171,7 @@ workflows:
       - build-ruby-2_5
       - build-ruby-2_6
       - build-ruby-latest
+      - build-jruby-9_2
       - build_monorepo
       - validate-cck:
           requires:

Gemfile

@@ -17,10 +17,5 @@ elsif !ENV['CUCUMBER_USE_RELEASED_GEMS']
 end
 
 gem 'cucumber-expressions', path: ENV['CUCUMBER_EXPRESSIONS_RUBY'] if ENV['CUCUMBER_EXPRESSIONS_RUBY']
-
-gem 'gherkin', path: ENV['GHERKIN_RUBY'] if ENV['GHERKIN_RUBY']
-
 gem 'cucumber-messages', path: ENV['CUCUMBER_MESSAGES_RUBY'] if ENV['CUCUMBER_MESSAGES_RUBY']
-
-# Use an older protobuf on JRuby
-gem 'google-protobuf', '~> 3.2.0.2' if RUBY_PLATFORM == 'java'
+gem 'gherkin', path: ENV['GHERKIN_RUBY'] if ENV['GHERKIN_RUBY']

README.md

@@ -15,7 +15,7 @@ your team.
 
 Where to get more info:
 
- * The main website: https://cucumber.io/ 
+ * The main website: https://cucumber.io/
  * Documentation: https://cucumber.io/docs
  * Ruby API Documentation: http://www.rubydoc.info/github/cucumber/cucumber-ruby/
  * Support forum: https://groups.google.com/group/cukes
@@ -28,7 +28,7 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for info on contributing to Cucumber.
 * Ruby 2.5
 * Ruby 2.4
 * Ruby 2.3
-* JRuby 9.1
+* JRuby 9.2 (with [some limitations](https://github.com/cucumber/cucumber-ruby/blob/master/docs/jruby-limitations.md))
 
 ## Code of Conduct
 

docs/jruby-limitations.md

@@ -0,0 +1,40 @@
+# Cucumber and JRuby limitations
+
+`cucumber` can be executed on `JRuby` (tested with `9.2`), although some of the features
+are not available on this platform.
+
+## Defining steps with native languages
+
+There are currently three languages (Russian, Ukrainian and Uzbek) for which the step definition
+can not be written in native language.
+That means, for example, that you can not write the following code:
+
+```ruby
+Допустим('я ввожу число {int}') do |число|
+  calc.push число
+end
+```
+
+Instead, you have to write:
+```ruby
+Given('я ввожу число {int}') do |number|
+  calc.push number
+end
+```
+
+Of course, you can still write your feature files in a native language, for example, the following
+feature file can be executed on JRuby:
+
+```gherkin
+# language: ru
+Функционал: Сложение чисел
+  Чтобы не складывать в уме
+  Все, у кого с этим туго
+  Хотят автоматическое сложение целых чисел
+
+  Сценарий: Сложение двух целых чисел
+    Допустим я ввожу число 50
+    И затем ввожу число 70
+    Если я нажимаю "+"
+    То результатом должно быть число 120
+```

examples/i18n/Rakefile

@@ -4,29 +4,45 @@ task :cucumber do
   Dir["#{dir}/*"].sort.each do |f|
     next unless File.directory?(f)
     lang = f[dir.length + 1..-1]
-    if examples_working?(lang)
-      Dir.chdir(f) do
-        puts "DIR: #{f}"
-        rake('cucumber')
-      end
-    else
-      STDERR.puts %{
-    !!!!!
-    !!!!!
-    !!!!! SKIPPING #{lang} (The examples are out of date - please help update them)
-    !!!!!
-    !!!!!
-    }
+    message = examples_disabled?(lang)
+    unless message.nil?
+      STDERR.puts(message)
+      next
+    end
+
+    Dir.chdir(f) do
+      puts "DIR: #{f}"
+      rake('cucumber')
     end
   end
 end
 
 task default: :cucumber
 
+def examples_disabled?(lang)
+  return make_warning("SKIPPING #{lang} (The examples are out of date - please help update them)") unless examples_working?(lang)
+  return make_warning("SKIPPING #{lang}: examples have been disabled for JRuby.") if jruby_disabled_examples?(lang)
+end
+
+def jruby_disabled_examples?(lang)
+  return unless RUBY_PLATFORM == 'java'
+  %w[ru uk uz].include?(lang)
+end
+
 def examples_working?(lang)
   !%w[ar].index(lang)
 end
 
+def make_warning(msg)
+  %(
+    !!!!!
+    !!!!!
+    !!!!! #{msg}
+    !!!!!
+    !!!!!
+  )
+end
+
 def rake(args)
   ruby($PROGRAM_NAME, args)
 end

features/docs/defining_steps/nested_steps.feature

@@ -107,7 +107,7 @@ Feature: Nested Steps
       Liouville
       """
 
-  @spawn @todo-windows
+  @spawn @todo-windows @todo-jruby @wip-jruby
   Scenario: Backtrace doesn't skip nested steps
     Given a step definition that looks like this:
       """ruby

gem_tasks/examples.rake

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
 
-desc 'Run all exmples'
+desc 'Run all examples'
 task :examples do
   Dir['examples/*'].each do |example_dir|
     next if !File.directory?(example_dir) || %w[examples/tcl].index(example_dir)
+
     puts "Running #{example_dir}"
     Dir.chdir(example_dir) do
       raise "No Rakefile in #{Dir.pwd}" unless File.file?('Rakefile')

spec/cucumber/formatter/backtrace_filter_spec.rb

@@ -15,8 +15,8 @@ module Formatter
                      _anything__test/unit__anything_
                      _anything__Xgem/ruby__anything_
                      _anything__.rbenv/versions/2.3/bin/bundle__anything_]
-          trace << "_anything__#{RbConfig::CONFIG['rubyarchdir']}__anything_"
-          trace << "_anything__#{RbConfig::CONFIG['rubylibdir']}__anything_"
+          trace << "_anything__#{RbConfig::CONFIG['rubyarchdir']}__anything_" if RbConfig::CONFIG['rubyarchdir']
+          trace << "_anything__#{RbConfig::CONFIG['rubylibdir']}__anything_" if RbConfig::CONFIG['rubylibdir']
 
           @exception = Exception.new
           @exception.set_backtrace(trace)