Skip to content

Commit 9b6fcfb

Browse files
Revert "Add support for message formatters with dry runs (#1537)" (#1539)
This reverts commit b691021.
1 parent b691021 commit 9b6fcfb

File tree

3 files changed

+1
-19
lines changed

3 files changed

+1
-19
lines changed

CHANGELOG.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
1616

1717
### Fixed
1818

19-
- '--dry-run' now supports 'message' based-formatters
20-
([1537](https://github.com/cucumber/cucumber-ruby/pull/1537)
21-
[1496](https://github.com/cucumber/cucumber-ruby/issues/1496)
22-
[1488](https://github.com/cucumber/cucumber-ruby/issues/1488)
23-
[aurelien-reeves](https://github.com/aurelien-reeves))
2419
- `attach` can now handle null bytes in the data.
2520
([1536](https://github.com/cucumber/cucumber-ruby/pull/1536)
2621
[1529](https://github.com/cucumber/cucumber-ruby/issues/1529)

features/docs/cli/dry_run.feature

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,19 +26,6 @@ Feature: Dry Run
2626
2727
"""
2828

29-
Scenario: With message formatter
30-
Given a file named "features/test.feature" with:
31-
"""
32-
Feature: test
33-
Scenario:
34-
Given this step passes
35-
"""
36-
And the standard step definitions
37-
When I run `cucumber --dry-run --publish-quiet --format message`
38-
Then it should pass
39-
And output should be valid NDJSON
40-
And the output should contain NDJSON with key "status" and value "SKIPPED"
41-
4229
Scenario: In strict mode
4330
Given a file named "features/test.feature" with:
4431
"""

lib/cucumber/runtime.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,14 +233,14 @@ def filters # rubocop:disable Metrics/AbcSize
233233
filters << Filters::Randomizer.new(@configuration.seed) if @configuration.randomize?
234234
# TODO: can we just use Glue::RegistryAndMore's step definitions directly?
235235
step_match_search = StepMatchSearch.new(@support_code.registry.method(:step_matches), @configuration)
236-
filters << Filters::BroadcastTestCaseReadyEvent.new(@configuration)
237236
filters << Filters::ActivateSteps.new(step_match_search, @configuration)
238237
@configuration.filters.each { |filter| filters << filter }
239238
unless configuration.dry_run?
240239
filters << Filters::ApplyAfterStepHooks.new(@support_code)
241240
filters << Filters::ApplyBeforeHooks.new(@support_code)
242241
filters << Filters::ApplyAfterHooks.new(@support_code)
243242
filters << Filters::ApplyAroundHooks.new(@support_code)
243+
filters << Filters::BroadcastTestCaseReadyEvent.new(@configuration)
244244
filters << Filters::BroadcastTestRunStartedEvent.new(@configuration)
245245
filters << Filters::Quit.new
246246
filters << Filters::Retry.new(@configuration)

0 commit comments

Comments
 (0)