-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable color when output to file using --out
/ allow --color
to be a per-formatter option like --out
#1288
Comments
I like this idea. WDYT @mattwynne? |
Hello @danascheider long time no see! Yes, this seems like a good idea to me. |
I know! Life's been crazy. I might pick this up when I'm done with the other one I'm working on but don't want to leave a bunch of half-finished PR's lying around! |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. |
Hey, just noticed I said I'd pick this up when things calmed down. I'm taking a look at it now! |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Thankyou for the update. Once we get v10 out I plan on tackling a few of these long standing bugs. Just that we're so far behind on many of the deps I wanted to get them up to date first. |
I like that approch and think it is a good idea. |
Summary
It seems like the default behavior should be for formatters that are output to the screen to have color enabled by default, and formatters that are directed to files to have no color by default, so that you can open them in an editor and not see gobbledeygook.
The default should be overridable, however, in case you really did want to view the saved output on a terminal later (perhaps with
less -R
).Current Behavior
lib/cucumber/formatter/ansicolor.rb
only disables color if you redirect stdout, as incucumber > file
:However, it doesn't provide any way to disable color for when directing a specific formatter to a
file with:
Expected Behavior
1. Default behavior
Formatters that are output to the screen (
@io.tty?
) should have color enabled by defaultFormatters that are directed to files (
@io.is_a?(File)
) to have no color by default.The help says it is based on the output destination but that is not true when using
--out
.2. Ability to enable/disable color on a per-formatter basis (like
--out
)It would be nice if you could disable color on a per-formatter basis, like how you can direct to a
different output on a per-formatter basis.
Maybe something like this:
but since --color/--no-color is a global state, the last flag changes it for all formatters.
So the best you can do with --no-color is turn off color for all formatters, including the one
being output to a tty STDOUT.
Possible Solution
One solution/workaround would be to strip out color in
format_string
:That seems to work for me, striping out all color except the summary at the bottom. Probably not the best solution, though.
Probably should move
Cucumber::Term::ANSIColor.coloring?
so that it's an instance method instead of a class method...Steps to Reproduce (for bugs)
cucumber --format pretty --out pretty.txt --format progress features/
pretty.txt
contains unwanted color codes.Your Environment
cucumber-3.1.0
cucumber-rails-1.5.0
The text was updated successfully, but these errors were encountered: