Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add storybook with tailwindcss, shadcn-ui, and chromatic visual test server #96

Closed
MFarabi619 opened this issue Sep 10, 2024 · 0 comments · Fixed by #97
Closed
Assignees
Labels
📦dependencies Pull requests that update a dependency file

Comments

@MFarabi619
Copy link
Member

MFarabi619 commented Sep 10, 2024

What is the goal of this task?

Front-End development is notorious for being wildly painful experience. Designers are upset that their beautiful mockups aren't coming to life as they wanted them to, and developers are upset that design implementations aren't as straightforward as they could be, while not also scaling well.

This is not a technical issue, rather more of a communication+collaboration one. What if we could all just get along in peace? What if designers could design and developers could develop without blocking each other?

In order to address these challenges, we're supercharging our Design and Front-End workflows with the following for more vroom vroom:

Tailwind CSS Shadcn/ui Storybook Chromatic
image image image image
Write CSS but faster Make UI components but faster Document your frontend components and layouts See UI differences and run test suites

Using these tools at scale is a big step forward for us as it eliminates many design-dev handoffs, provide a quicker feedback loop

The inclusion of Storybook is also mentioned in ADR #40.

The Tailwind primitives have already been added to the cuHacking Design System Figma to be used by designers.

image

Describe Any Technical Challenges Your Forsee With This

  • Scaffolding anything in Nx has clearly proven to be a painful experience, as the default generators produce .cjs files rather than adhere to modern ESM syntax.
  • Storybook and Chromatic tests need to be integrated into the CI pipelines
  • Setting up design token integration with Figma

Additional context
Example use of Storybook from my side project:

image image

Design Systems from others:

@MFarabi619 MFarabi619 self-assigned this Sep 10, 2024
@github-project-automation github-project-automation bot moved this to Todo ⏭ in 🐞 2025 Sep 10, 2024
@MFarabi619 MFarabi619 moved this from Todo ⏭ to In Progress 🏃 in 🐞 2025 Sep 10, 2024
@MFarabi619 MFarabi619 linked a pull request Sep 11, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from ⏭ Todo to ✅ Done in 🐞 2025 Nov 19, 2024
@HasithDeAlwis HasithDeAlwis added the 📦dependencies Pull requests that update a dependency file label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦dependencies Pull requests that update a dependency file
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants