Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate data against schema instead of by parsing #93

Closed
dellisd opened this issue Jun 1, 2021 · 0 comments · Fixed by #100
Closed

Validate data against schema instead of by parsing #93

dellisd opened this issue Jun 1, 2021 · 0 comments · Fixed by #100
Assignees
@dellisd
Labels
component: server Tasks relating to the backend server which serves map data
Milestone
Initial Launch

Comments

@dellisd
Copy link
Member

dellisd commented Jun 1, 2021

Use a JSON schema to validate map data when loading rather than trying to parse it. Using a schema can provide better error messages to indicate why the data wasn't parsed.

In addition, the command line component of the server can include a mode to test the data without actually starting the server.
e.g. ./server.jar --test data.json could validate the data and then terminate.

Requires #85 to be complete first.
@dellisd dellisd added the component: server Tasks relating to the backend server which serves map data label Jun 1, 2021
@dellisd dellisd added this to the Initial Launch milestone Jun 1, 2021
@dellisd dellisd self-assigned this Jun 1, 2021
@dellisd dellisd mentioned this issue Jul 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dellisd dellisd

Labels
component: server Tasks relating to the backend server which serves map data
Projects
None yet
Milestone
Initial Launch
Development

Successfully merging a pull request may close this issue.

Validate data on server using schema cuhacking/atlas
1 participant
@dellisd