Use command -v instead of which

Author: cv

cli/cli.go

@@ -278,7 +278,7 @@ func execCommand(cmd *cobra.Command, args []string) error {
 			editor = env("EDITOR")
 			if editor == "" {
 				logrus.Debug("$EDITOR not set, trying $(which vim)...")
-				editor = "$(which vim)"
+				editor = "$(command -v vim)"
 			}
 		}
 		cmdline := []string{"sh", "-c", strings.Join([]string{editor, src}, " ")}

cli/cli_test.go

@@ -223,7 +223,7 @@ func TestExecCommand(t *testing.T) {
 		syscallExec = func(argv0 string, argv []string, envv []string) error {
 			called = true
 			assert.Equal(t, "/bin/sh", argv0)
-			assert.Equal(t, []string{"sh", "-c", "$(which vim) /path/to/foo"}, argv)
+			assert.Equal(t, []string{"sh", "-c", "$(command -v vim) /path/to/foo"}, argv)
 			return nil
 		}